Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fva infeasibility #14

Merged
merged 8 commits into from
Oct 24, 2014
Merged

Fva infeasibility #14

merged 8 commits into from
Oct 24, 2014

Conversation

phantomas1234
Copy link
Collaborator

Emre fixing fva problems ...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) when pulling 3df7477 on FVA_infeasibility into bd541cf on devel.

try: # this is an alternative solution to what I did above with flags
assert ((lb_higher_ub.lower_bound - lb_higher_ub.upper_bound) < 1e-6).all() # Assert that these cases really only numerical artifacts
except AssertionError as e:
print zip(model.reactions, (lb_higher_ub.lower_bound - lb_higher_ub.upper_bound) < 1e-6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we start using loggers instead of print for getting handled exceptions information?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) when pulling cd526fb on FVA_infeasibility into 1cdb8bf on devel.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.61%) when pulling 0fc01aa on FVA_infeasibility into 1cdb8bf on devel.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) when pulling 53c0364 on FVA_infeasibility into 4955212 on devel.

@phantomas1234
Copy link
Collaborator Author

@joaocardoso can you merge this if you thinks it's ok now?

the-code-magician added a commit that referenced this pull request Oct 24, 2014
@the-code-magician the-code-magician merged commit c65ea31 into devel Oct 24, 2014
@phantomas1234
Copy link
Collaborator Author

@meono can I delete this branch? Or are you still using it?

@meono
Copy link
Contributor

meono commented Oct 24, 2014

@phantomas1234 go ahead.

@phantomas1234 phantomas1234 deleted the FVA_infeasibility branch October 24, 2014 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants