Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #231

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Error handling #231

wants to merge 13 commits into from

Conversation

NikkiBytes
Copy link
Contributor

Upgraded with comprehensive error catching in the validation endpoint and schema metadata endpoint.
Added a a test file that tests scenarios in the validation endpoint.

@NikkiBytes
Copy link
Contributor Author

@newgene just pushed a fourmat check update, this has been reviewed and is ready to merge.

@newgene
Copy link
Member

newgene commented Aug 23, 2023

@NikkiBytes just to make sure we (you, @marcodarko and I) are on the same page about the error-handling behavior, can you please document all handled cases in this PR. A table looks like this might be an option:

is schema.org class class exists class contains validation ... /schema/<id> status code /schema/<id>/validation status code
200 404

@NikkiBytes
Copy link
Contributor Author

NikkiBytes commented Sep 5, 2023

# Is schema.org class/property Is registered schema class/property Class contains validation /schema/<id> status code /schema/<id>/validation status code
1 404 (Unknown/invalid schema id) 404 (Unknown/invalid schema id)
2 200 404(validation field not found)
3 200 200
4 404 (Metadata from schema.org cannot be retrieved this way) 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants