-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use describeprocess all to speed up the creation of the class #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested yet ... but code changes look good.
birdy/client/base.py
Outdated
""" | ||
if processes is None: | ||
# Get the description for all processes in one request. | ||
ps = self._wps.describeprocess('all') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we assume, we always get a list of processes. Which is right :) But need to adapt owslib PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about backward-compatibility? I can also make a pre-release package of owslib on the birdhouse channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your're right, if a server had only one process, this would break.
I guess we should try to do something backward compatible, but doing this elegantly might be complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last push includes a fix to make the change backward compatible. It only requires owslib to bump version. The change almost divides the test run time by half.
…cause when the server is local, we can use a reference with file://
@cehbrecht Ok, ready to go, want to take a last look ? |
@huard I'm ok with it. Please merge :) |
Overview
This PR closes #90
Changes:
Related Issue / Discussion
Requires: geopython/OWSLib#555