Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: coordinates field #150

Closed
stereobooster opened this issue Apr 10, 2019 · 5 comments
Closed

Feature: coordinates field #150

stereobooster opened this issue Apr 10, 2019 · 5 comments

Comments

@stereobooster
Copy link

stereobooster commented Apr 10, 2019

Add field to input longitude/latitude. Also we can consider supporting https://plus.codes/ or https://en.wikipedia.org/wiki/Open_Location_Code

@stereobooster stereobooster changed the title Feature: coordinate field Feature: coordinates field Apr 10, 2019
@birkir
Copy link
Owner

birkir commented Apr 10, 2019

https://github.com/birkir/prime/tree/master/packages/prime-field-geopoint

Already implemented and released in 0.3.4

@stereobooster
Copy link
Author

Oh nice! I missed it

@stereobooster
Copy link
Author

It is not part of the core though. Is it intended?

@agustif
Copy link

agustif commented Apr 10, 2019

It is not part of the core though. Is it intended?

None of the fields are, all of theme are on their own package, and also based on the prime-field scaffolding separate package, it's a monorepo afterall.

It makes sense like it is, you can add extra fields as needed by project requirements that way, instead of having to trimm down on a fat core

@birkir
Copy link
Owner

birkir commented Apr 10, 2019

What @agustif said is correct.

But what gets installed by default with @primecms/core, we can decide upon. Currently it's all packages besides geopoint. I'll add it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants