Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Redirect "essentials" docs to wiki #205

Merged
merged 5 commits into from Aug 27, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Aug 18, 2020

This PR redirects docs links to their wiki counterparts. Most of these docs are in the "Essentials" section, as those happen to be the ones already completed on the wiki.

Note that while links to the wiki have an external link icon, they don't open in a new window...but I'm open to feedback if those reviewing this PR think otherwise.

Review Guidance

An active visual review of the main page of the preview site should suffice to review this pull request.

  • Look at the commits and verify all changes are on the front page (an image is added, not removed, so there can't possibly be any conflicts introduced)
  • f46eb31 - does the top admonition box render ok, and is the message good?
  • 4b6636b - quick links were removed; does the site show any artifacts or undesirable items as a result?
  • d9c65d9 - are links correct? are there any other mistakes that cause links to come across as careless or confusing?

@Bayernatoor
Copy link
Member

I prefer that a new tab be opened when clicking a link. I asked a few people and consensus was "new tab". (small sample group though :) )

f46eb31 - Looks good, box renders fine and the message is clear and concise.

Not a big concern but the "Bisq Docs" logo is missing on the new version.

Screenshot from 2020-08-21 11-19-57

4b6636b - No undesirable items or artifacts remain

d9c65d9 - All links make sense and redirect to the correct article.

Except top wiki link, which does not show an external link symbol.
@m52go
Copy link
Contributor Author

m52go commented Aug 27, 2020

@Bayernatoor thanks again for reviewing! I've made all wiki links with the external link symbol open in a new window.

Could you clarify the bit about the "Bisq Docs" logo missing? It doesn't seem to be missing on the staging site or when I run it locally.

Screenshot from 2020-08-27 08-43-58-touched

@Bayernatoor
Copy link
Member

Yep you're right, odd, i don't remember seeing it when i reviewed. I double checked locally and it's there! All good :)

@m52go m52go merged commit 50679cc into bisq-network:master Aug 27, 2020
@m52go m52go deleted the redirect-docs-wiki branch August 27, 2020 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants