Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian portuguese #281

Closed
wants to merge 35 commits into from
Closed

Brazilian portuguese #281

wants to merge 35 commits into from

Conversation

FKrauss
Copy link
Contributor

@FKrauss FKrauss commented Nov 5, 2019

as per the documentation I have "integrated" the pt-br language into the website and tested it locally.

Images are all in place, text is good and a few corrections were made in directly in the code so it wouldn't overflow their space.

I made a couple additions to it too:

  1. I started a small tutorial on how to integrate a new language - it's not 100% great but it is a start. I'll add more to it when I integrate another language
  2. included a small telegram logo in svg in the images/community folder
  3. included said telegram logo in the pt-BR page for community with the link to the Brazilian telegram support group
  4. removed a bunch of whitespace in the dao_content_tr.yml file

Let me know what you think!

Cheers!

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FKrauss -- some notes:

This PR was a bit hard to review as-is because of the commit history...if you look at the "Files Changed" tab on the top of this page, you'll see this PR includes a lot of changes from the extra unrelated commits. I ended up cherry-picking the commits you made to do a proper review, and would need you to do the same to clean this PR up before merging. Ideally it would also be rebased onto a more recent version of the master branch.

I did it already here on my repository. I can explain how to do it if you like, or you can give me push access to your bisq-website repository and I can just push what I have.

Some corrections:

  1. These links on the bottom of the DAO page are missing spaces. I've added a suggested commit to fix this issue.

  2. All pictures on the DAO page are still in English. Would you mind translating them? They're SVGs so you can manipulate the text in the SVG file. I've suggested corrections that fix this issue.

  3. It looks like only some FAQ updates from the v1.2 PR made it here. For example, the payment methods section isn't current on this PR. Please check out this PR for reference on everything that was updated.

  4. I think it would be better to make the language attribute in page front matter language: Português instead of language: Português (BR). The flag accomplishes the distinction between PT-PT and PT-BR.

I think this is everything, but it will be easier to be more confident once the cruft is removed and these corrections are made.

pt-BR/community.md Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/dao_content_tr.yml Outdated Show resolved Hide resolved
_data/dao_content_tr.yml Outdated Show resolved Hide resolved
_data/dao_content_tr.yml Outdated Show resolved Hide resolved
_data/dao_content_tr.yml Outdated Show resolved Hide resolved
_data/dao_content_tr.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
@m52go
Copy link
Contributor

m52go commented Nov 27, 2019

@FKrauss I've integrated all the feedback except the FAQs, which need to be updated in Portuguese (item 3 from my review comment).

@FKrauss FKrauss closed this Nov 27, 2019
@FKrauss FKrauss mentioned this pull request Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants