Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pt br #301

Merged
merged 40 commits into from Dec 2, 2019
Merged

Pt br #301

merged 40 commits into from Dec 2, 2019

Conversation

FKrauss
Copy link
Contributor

@FKrauss FKrauss commented Nov 27, 2019

Adding Brazilian portuguese to the website, following many comments and a some restructuring that was required from the previous PR about brazilian portuguese

Fabio Krauss and others added 30 commits November 12, 2019 12:03
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there, please see comments and suggested commits.

_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
_data/pt-BR.yml Outdated Show resolved Hide resolved
FKrauss and others added 2 commits November 28, 2019 22:30
Co-Authored-By: Steve Jain <mfiver@gmail.com>
@FKrauss
Copy link
Contributor Author

FKrauss commented Nov 28, 2019

Alright I added a new commit that contains a few updated strings from Transifex. These were not reviewed there and were lagging. Now they should be correct.

@m52go
Copy link
Contributor

m52go commented Dec 2, 2019

@FKrauss thanks. I just fixed 1 minor issue in FAQ and also fixed a merge conflict.

One last thing, and then I think it's ready to merge. Is there any way you can think of to make the following strings smaller? They don't fit the layout.

In pt-BR.yml:

  • liAllDownloadsText: Ir para a página de downloads
  • liArchText: "Repositório dos Usurários de Arch "

Screenshot from 2019-12-02 12-08-26

arch linux repo & go to download pages
@m52go
Copy link
Contributor

m52go commented Dec 2, 2019

ACK

@FKrauss
Copy link
Contributor Author

FKrauss commented Dec 2, 2019

All right, fixed these last two. and fixed them in transifex, so next time it won't cause the same problem again

@m52go m52go merged commit 35cc390 into bisq-network:master Dec 2, 2019
@FKrauss FKrauss deleted the pt-br branch December 2, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants