Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display actively traded markets on the bisq.network/markets page #407

Merged

Conversation

wiz
Copy link
Member

@wiz wiz commented Nov 23, 2020

Adds a script to update list of Bisq markets from the active markets API, and updates the list using that script.

For more information see mempool/mempool#189, bisq-network/bisq#4831, and bisq-network/bisq#4826

Adds a script to update list of Bisq markets from the active markets API, and updates the list using that script.

For more information see mempool/mempool#189, bisq-network/bisq#4831, and bisq-network/bisq#4826
@wiz
Copy link
Member Author

wiz commented Nov 23, 2020

@wiz wiz marked this pull request as ready for review November 23, 2020 15:00
@m52go
Copy link
Contributor

m52go commented Nov 24, 2020

Thanks, looks good to me and script seemed to run well.

Would you say this is something that should be run every so often, maybe every 6 months?

@wiz
Copy link
Member Author

wiz commented Nov 24, 2020

Yeah or whenever something new is added

@m52go
Copy link
Contributor

m52go commented Nov 24, 2020

ACK

@m52go m52go merged commit adafc27 into bisq-network:master Nov 24, 2020
@wiz wiz deleted the update-markets-list-using-active-markets-api branch November 24, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants