Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markets API: only display actively traded assets / markets #4826

Closed
wiz opened this issue Nov 20, 2020 · 3 comments · Fixed by #4831
Closed

Markets API: only display actively traded assets / markets #4826

wiz opened this issue Nov 20, 2020 · 3 comments · Fixed by #4831

Comments

@wiz
Copy link
Member

wiz commented Nov 20, 2020

Currently when bisq is launched with --dumpStatistics=true we output a crypto_currency_list.json and fiat_currency_list.json which is what is served from the Markets API at https://bisq.markets/api/markets

However, this is a very large list mostly full of de-listed coins that were never even traded on Bisq, or fiat currencies that aren't actively traded on Bisq. Many API users query every asset on the list every few minutes, which causes a huge load on the server.

Can you please create new files of only actively traded crypto and fiat assets?
スクリーンショット 2020-11-19 23 59 33

@wiz
Copy link
Member Author

wiz commented Nov 20, 2020

@jmacxx can you look into this

@ghost
Copy link

ghost commented Nov 20, 2020

I'm assuming that an asset traded within the past 365 days is active. That would produce lists with ~24 fiat and ~24 altcoins.

Or would you prefer a narrower definition, e.g. 1 month, or 1 day?

@wiz
Copy link
Member Author

wiz commented Nov 22, 2020

Thanks, that's probably fine and we can always tweak it in the future if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants