Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve withdraw fee calculation #3106

Closed
huey735 opened this issue Aug 19, 2019 · 4 comments

Comments

@huey735
Copy link
Member

commented Aug 19, 2019

I tried to withdraw some BSQ from Bisq with a 1 sat/byte fee but the software miscalculated it and it ended outputting a value bellow 1 sat/byte. This caused the transaction to not be broadcast. I had to resync the SPV file and increase the custom withdraw transaction fee to 2 sat/byte.

There are two possible solutions:

  • a) set the withdraw transaction fee to an obligatory minimum of 2 sat/byte
  • b) fix the calculation of the transaction fee

I'd also like to say that this is a first occurrence, I've withdrawn many times at 1 sat/byte without coming across this issue.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

The calculation works usually pretty well. It is a bit complex, and complex to explain as well. Which fee was used in the tx? Was it far off? Should not be more the 10% off.

@huey735

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

These were the values:
The necessary transaction fee is: 0.00000733 BTC (0.9 satoshis/byte)
Transaction size: 0.816 Kb

So probably increasing the minimum to 2 sat/byte is the easier solution. This is the type of silent error that may leave people in the dark.

@huey735

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@christophsturm

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

I'm going to work on this

wiz added a commit to wiz/bisq that referenced this issue Oct 10, 2019
@sqrrm sqrrm closed this in 679985d Oct 10, 2019
sqrrm added a commit that referenced this issue Oct 17, 2019
* Temporarily disable onion host for @KanoczTomas's BTC node

* Add Ergo (ERG) without Bouncy Castle dependency.

See #3195.

* List CTSCoin (CTSC)

* Tweak the English name of Japan Bank Transfer payment method

* Add mediator prefix to trade statistics

* List Faircoin (FAIR)

* List uPlexa (UPX)

* Remove not used private methods from BisqEnvironment

* Add onInitP2pNetwork and onInitWallet to BisqSetupListener

- Rename BisqSetupCompleteListener to BisqSetupListener
- Add onInitP2pNetwork and onInitWallet to BisqSetupListener
- make onInitP2pNetwork and onInitWallet default so no impl. required

* Start server at onInitWallet and add wallet password handler

- Add onInitWallet to HttpApiMain and start http server there
- Add onRequestWalletPassword to BisqSetupListener
- Override setupHandlers in HttpApiHeadlessApp and adjust
setRequestWalletPasswordHandler (impl. missing)
- Add onRequestWalletPassword to HttpApiMain

* Add combination (Blockstream.info + Mempool.space) block explorer

* Revert "Temporarily disable onion host for @KanoczTomas's BTC node"

This reverts commit d333520.

* Temporarily disable KanoczTomas btcnode on both onion and clearnet

* Refactor BisqApp - update scene size calculation

* Refactor BisqApp - update error popup message build

* Refactor BisqApp - move icon load into ImageUtil

* Remove unused Utilities

* Increase minimum TX fee to 2 sats/vByte to fix #3106 (#3387)

* Fix mistakes in English source (#3386)

* Fix broken placeholders

* Replace non existing pending trades screen with open trades screen

* Update core/src/main/resources/i18n/displayStrings.properties

Co-Authored-By: Steve Jain <mfiver@gmail.com>

* Update message in failed trade popup

* Refactor BisqEnvironment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.