Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisq UI very laggy/slow on Windows 8 #3308

Closed
fresheneesz opened this issue Sep 22, 2019 · 29 comments
Closed

Bisq UI very laggy/slow on Windows 8 #3308

fresheneesz opened this issue Sep 22, 2019 · 29 comments
Labels
a:bug an:investigation is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:Windows

Comments

@fresheneesz
Copy link

fresheneesz commented Sep 22, 2019

Bisq is very laggy. It has been this way for a while, and persists in the latest version v1.1.6. It often takes a full second to register button clicks, especially tabs like "Buy BTC" and "Sell BTC", possibly because they have lots of data to load. However these pages should be cached, especially if you've just gone to the page - there should be no reason that a new view needs to be loaded from scratch. And if those kinds of things take a long time to render, they should be preloaded.

It seems clear to me that background processes are blocking the UI. Those background processes should be run in a separate thread from the UI so that doesn't happen. For example, last time I started up Bisq, the UI took upwards of 5 seconds to respond to actions. This happens randomly at other times too.

I'm not sure if maybe memory problems are related: #3307.

@fresheneesz fresheneesz changed the title Bisq UI very laggy/slow on Windows 7 Bisq UI very laggy/slow on Windows 8 Sep 22, 2019
@Oscar65
Copy link
Contributor

Oscar65 commented Sep 23, 2019

This happen in my computer too. I thought that is because java is slow and my computer is old (editor Intelij IDEA/android-studio also are laggy/slow).

@stale
Copy link

stale bot commented Dec 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Dec 26, 2019
@fresheneesz
Copy link
Author

This is still a very relevant usability problem.

@stale stale bot removed the was:dropped label Dec 26, 2019
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 18, 2020
@ripcurlx ripcurlx added this to To do in Critical Bugs Board via automation Feb 18, 2020
@ripcurlx ripcurlx added the is:critical https://bisq.wiki/Critical_bug label Feb 18, 2020
@cbeams cbeams added the a:bug label Feb 27, 2020
@omarabid
Copy link

Any updates on this? The platform is unusable.

cd2357 added a commit to cd2357/bisq that referenced this issue May 7, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
@chimp1984
Copy link
Contributor

TradeStatistics and DaoState objects are growing and might be a reason for those issues. A fix for TradeStatistics is in progress.

cd2357 added a commit to cd2357/bisq that referenced this issue Sep 16, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
@sijanec
Copy link

sijanec commented Oct 18, 2020

I am also on low-end hardware and the app is not usable at all. Opening a drop-down menu takes 10 seconds, scrolling is a pain.

A lightweight web-interface would be in my opinion a bit faster than the current GUI.

@cd2357
Copy link
Contributor

cd2357 commented Oct 18, 2020

I am also on low-end hardware and the app is not usable at all. Opening a drop-down menu takes 10 seconds, scrolling is a pain.

That might happen if the bottom bar is saying that DAO is synchronizing right now. That is generally an intensive process.

In my experience, once that process is over, the UI is much more responsive.

Also, depends what you mean with low-end hardware. Bisq needs at least 2-3GB free RAM. Even with "synchronizing DAO" task in progress, any UI click responds within 1-2 seconds for me on a 2014 macbook, even faster after that task is done.

@cd2357
Copy link
Contributor

cd2357 commented Oct 18, 2020

An API is being worked on, which will make a web-UI possible soon.

@sijanec
Copy link

sijanec commented Oct 19, 2020 via email

@aloxyz
Copy link

aloxyz commented Nov 5, 2020

I have the very same problem.

@fresheneesz
Copy link
Author

which will make a web-UI possible soon.

What do you mean a web-UI? You mean a website that runs Bisq? Or do you mean something like a downloadable chromium app?

@sijanec
Copy link

sijanec commented Nov 5, 2020 via email

@fresheneesz
Copy link
Author

fresheneesz commented Nov 6, 2020

why download a browser when you already have one?

Because a downloaded browser is stable and doesn't change until the user opts in to upgrade. When you use a web app, you're literally installing a (potentially different) application every single time you load a page. This has massively more attack surface than a downloaded app you can verify with deterministic builds.

Please don't make Bisq a web app. Just improve the downloadable program.

Its perfectly fine to have Bisq information on a website that shows you what the market is doing. But as soon as you have people sending money on a website, you're asking for phishing attacks and other shenanigans. Please don't replace the desktop app with a web app! Don't make a web interface for trading at all!!

@chimp1984
Copy link
Contributor

The reasons why Bisq has performance issues are engineering problems which can be solved with enough dev power. But that is a scarce resource since ever. The UI technology would not make the difference. Its a highly complex application and optimization is always only done once problems occure and they are often not easy.
But be assured its high on our prio list. We do improvements each release, but with out limited resources it takes some time.

A web-app would not work for the level of decentralisation Bisq provides.

@fresheneesz
Copy link
Author

fresheneesz commented Nov 6, 2020

@chimp1984 I agree a web-app wouldn't work for the level of decentralization Bisq aims to provide. However, I don't think the complexity of the application has anything to do with the performance issues Bisq's UI suffers from - at least not the kinds this ticket is about. The UI technology could very well make a huge difference in the operation of the UI. Its pretty clear to me that a lot of heavy non-UI processing is done on the same thread as the UI runs on. In well designed applications, this isn't the case - UI gets a separate thread from the non-UI code for this very reason. This may not be an easy thing to fix, but changing to a new UI technology may be a simple way to fix it.

@sijanec
Copy link

sijanec commented Nov 6, 2020 via email

@ghubstan
Copy link
Member

ghubstan commented Nov 6, 2020

@sijanec, as @cd2357 mentioned, steady progress is being made on a gRPC API -- see https://github.com/orgs/bisq-network/projects/17.

Once the gRPC API and CLI is stabilized, released, accepted, etc., a closer look will be taken at a grpc-gateway (reverse proxy) that would make the headless server able to serve HTTP 1.1 RESTful clients too, but UIs will not built by Bisq devs. There is a POC for this: https://github.com/ghubstan/bisq-grpc-gateway. There is no consensus about going forward with the reverse proxy idea, but it will be examined, then rejected or approved after (and if) the gRPC API achieves its purpose.

Pushing back on all this is the lack of devs who like to work cheap -- to paraphrase @chimp1984 -- but people are working on solving the problems you've found.

@sijanec
Copy link

sijanec commented Nov 7, 2020 via email

@chimp1984
Copy link
Contributor

chimp1984 commented Nov 7, 2020

@fresheneesz

I agree a web-app wouldn't work for the level of decentralization Bisq aims to provide. However, I don't think the complexity of the application has anything to do with the performance issues Bisq's UI suffers from - at least not the kinds this ticket is about. The UI technology could very well make a huge difference in the operation of the UI. Its pretty clear to me that a lot of heavy non-UI processing is done on the same thread as the UI runs on. In well designed applications, this isn't the case - UI gets a separate thread from the non-UI code for this very reason. This may not be an easy thing to fix, but changing to a new UI technology may be a simple way to fix it.

Great thanks for the lecture in CS ;-)

The offer views are pretty snappy on my 6 year old iMac. Maybe you have some local issues with either DAO not in sync or some other issues. Most devs are on Linux or OSX so windows is less tested, but as there are not many more reports about what you described I assume its a local issue. Only known issue is when the DAO is syncing after longer not using Bisq it slows down all, but there is work planned to improve that and it only affects users who dont regularily use Bisq.

@fresheneesz
Copy link
Author

on my 6 year old iMac

This is a windows issue. The underlying code is different on windows, no?

as there are not many more reports about what you described I assume its a local issue

I see at least four reports above. For a small subset of users on a relatively small program like Bisq, that's a lot. I assume you are aware of the concept that if there is 1 person reporting an issue, 10 to 100 are probably seeing the issue. So I don't understand the dismissal of these reports as a "local issue".

Regarding the web UI: as long as no one is advocating that anybody connect to a server they're not running themselves, I think that's perfectly reasonable.

@chimp1984
Copy link
Contributor

This is a windows issue. The underlying code is different on windows, no?

No. Java is cross platform. There are very tiny, for this case irrelevant differences.

@sijanec
Copy link

sijanec commented Nov 8, 2020 via email

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 9, 2020

As we are stuck on Java 10 and an outdated JavaFX version for more than a year already, I expect as soon as #4242 gets merged to get rid of a couple of nasty memory issues we are seeing right now. Maybe also delivers some improvements on CPU consumption on Windows, but I haven't tested it personally just yet.

@sTiKyt
Copy link

sTiKyt commented Mar 16, 2021

UI Laggs are impossible to work with, i'm having issues on Arch

@cd2357
Copy link
Contributor

cd2357 commented Mar 16, 2021

@sTiKyt have you tried waiting until after "Synchronizing DAO" finishes?

That's a very taxing process from what I've seen, works much smoother for me after it finishes.

@sTiKyt
Copy link

sTiKyt commented Mar 17, 2021

@sTiKyt have you tried waiting until after "Synchronizing DAO" finishes?

That's a very taxing process from what I've seen, works much smoother for me after it finishes.

Yes, i am "Synchronized"... And i reported UI laggs AFTER i got synchronized

@cd2357
Copy link
Contributor

cd2357 commented May 9, 2021

Should be fixed in the most recent release (v1.6.4) which brings several UI performance improvements and generally reduces system resource consumption (especially RAM). Please try it out and let us know if it's still an issue for you.

@cd2357 cd2357 closed this as completed May 9, 2021
Critical Bugs Board automation moved this from To do to Done May 9, 2021
@maildeno0
Copy link

Bisq 1.8.2 and it is still slow as worm. It became even slower than 1.6.4. Nothing except windows and bisq is installed.

@ghost
Copy link

ghost commented Feb 3, 2022

@maildeno0 if you could share your bisq.log perhaps we'll notice a reason for the slowness. Perhaps there is a network sync process going on in the background or something.

From my own perspective, Bisq on Windows seems faster than Linux, so that makes me surprised to read your report.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug an:investigation is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:Windows
Projects
Development

No branches or pull requests