Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java heap space error MacOS Bisq #3786

Closed
r3n3x opened this issue Dec 13, 2019 · 6 comments
Closed

Java heap space error MacOS Bisq #3786

r3n3x opened this issue Dec 13, 2019 · 6 comments
Labels
a:bug is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:macOS

Comments

@r3n3x
Copy link

r3n3x commented Dec 13, 2019

#3316 # Description

Out of nowhere, Error pop-up with Java heap space error appeared and I am tasked to open a github issue :-)
App unresponsive. Have to force-quit

Version

v1.2.4

Steps to reproduce

keep running on Mac Mini Catalina MacOS for several days

Expected behaviour

n/a

Actual behaviour

n/a

Screenshots

Screen Shot 2019-12-13 at 8 05 21 PM

Device or machine

Catalina 10.15.1, Mac Mini late-2014

Additional info

LOG EXCERPT

Dec-11 19:49:45.884 [JavaFX Application Thread] INFO b.c.d.s.DaoStateService: New Block added at blockHeight 607640
Dec-11 19:49:45.884 [JavaFX Application Thread] INFO b.c.d.n.p.BlockParser: Parsing 0 transactions at block height 607640 took 0 ms
Dec-11 19:49:45.884 [JavaFX Application Thread] INFO b.c.d.s.DaoStateService: Parse block completed: Block height 607640, 0 BSQ transactions.
Dec-11 19:50:03.571 [Save-file-task-6340] ERROR b.c.s.FileManager: Error in saveToFile toProtoMessage: DaoStateStore, /Users/r3n3/Library/Application Support/Bisq/btc_mainnet/db/DaoStateStore
Dec-11 19:50:05.782 [Save-file-task-6340] ERROR b.c.s.FileManager: Error at saveToFile, storageFile=/Users/r3n3/Library/Application Support/Bisq/btc_mainnet/db/DaoStateStore java.lang.RuntimeException: java.lang.OutOfMemoryError: Java heap space
at bisq.common.storage.FileManager.saveToFile(FileManager.java:200)
at bisq.common.storage.FileManager.lambda$new$0(FileManager.java:83)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.OutOfMemoryError: Java heap space
at com.google.protobuf.AbstractMessageLite.toByteArray(AbstractMessageLite.java:69)
at bisq.common.storage.FileManager.saveToFile(FileManager.java:195)
at bisq.common.storage.FileManager.lambda$new$0(FileManager.java:83)
at bisq.common.storage.FileManager$$Lambda$177/75024191.call(Unknown Source)
... 5 common frames omitted

Dec-11 19:50:08.000 [JavaFX Application Thread] INFO b.c.b.w.BsqWalletService: updateBsqBalance took 58 ms
Dec-11 19:50:08.085 [JavaFX Application Thread] WARN b.c.d.m.DaoStateMonitoringService: Conflict with seed nodes: We received a block hash from peer 5f4wdwjruxauizpc.onion:9999 which conflicts with our block hash.
my daoStateHash=StateHash{
height=607640,
hash=e7f66e5f8a0ae56a83756fb332704e43dd0b231e,
prevHash=b7e0fdb495b631b39406e5884d1e9994151332f9
}
peers daoStateHash=StateHash{
height=607640,
hash=40c60563d0b0db8811fabdba8afbaee7f62b87b2,
prevHash=9879a200291df966130c6e4d3ce337a9933e7c36
}
Dec-11 19:50:08.177 [JavaFX Application Thread] WARN b.c.d.m.DaoStateMonitoringService: Conflict with seed nodes: We received a block hash from peer iaqzas3rsocbphum.onion:9999 which conflicts with our block hash.
my daoStateHash=StateHash{
height=607640,
hash=e7f66e5f8a0ae56a83756fb332704e43dd0b231e,
prevHash=b7e0fdb495b631b39406e5884d1e9994151332f9
}

@esackbauer
Copy link

Same here with Debian Linux. After running several hours on my Debian 10 VM.

Relevant log part attached.
bisq.log

@ripcurlx
Copy link
Contributor

Related to: #3128, #3657, #3918, #3917, #3787, #3786, #3686, #3677, #3343

@HausIndustries
Copy link

I have the lazy fix although there does need to be a real one implemented. You just click the report to github and it does take a minute for it to start up but at least it doesnt freeze everything.

@r3n3x
Copy link
Author

r3n3x commented Mar 13, 2020

Since this bug seems not to be addresses/solved yet, at this moment I am not participating - as in keeping trades open and BisQ running. (I think this bug hinders growth of adoption).
I am not skilled to participate in the bug-fixing myself, sorry.

cd2357 added a commit to cd2357/bisq that referenced this issue May 7, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
@chimp1984
Copy link
Contributor

I guess it is related to growing data kept in memory. Trade statistics is one of the large data structure and work is in progress to fix that. The other one is the DaoState data, which will be more difficult to fix.

cd2357 added a commit to cd2357/bisq that referenced this issue Sep 16, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
@cd2357
Copy link
Contributor

cd2357 commented May 9, 2021

Should be fixed in the most recent release (v1.6.4) which brings several UI performance improvements and generally reduces system resource consumption. Also, several data structures have been optimized since this was reported (>1y ago).

Please try out the latest version and let us know if it's still an issue for you.

@cd2357 cd2357 closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:macOS
Projects
None yet
Development

No branches or pull requests

7 participants