Fix broadcast issues #1638
Merged
Fix broadcast issues #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We handle the timeout by default with a call onSuccess to reduce potential problems with delayed broadcasts.
- remove temp dependencyVerification items to not break other builds as dependencies have changed but they are still not correctly resolved ;-(
chirhonul
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
utACK 9a9d574.
In commit 9a9d574 we are removing all the SHA256 checksum verifications for the dependencies we have.
This seems less than ideal, and I understand after discussion with @ManfredKarrer that it's meant to be temporary until the current build issues can be addressed. If so, I'd suggest adding a comment to build.gradle to note this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
bisq-network/bisq-common#37
bisq-network/bisq-core#165