Fix broadcast issues #37
Conversation
See: bisq-network/bitcoinj@1fd8909 If the broadcastToAllPeers flag is true and we would use all peers for broadcasting for some unknown reason we don not hear back from the broadcast or hear back very late (mostly > 1 minute). If we do not use all peers but at least 1 less it works reliable fast (about 3 seconds). It is not clear why that happens but is likely related to some behaviour in other classes for handling the events to hear back from the nodes.
- remove temp dependencyVerification items to not break other builds as dependencies have changed but they are still not correctly resolved ;-(
There was a problem hiding this comment.
utACK 0ceb5f3.
The new commit for libdohj refers to:
The old commit was:
The only meaningful diff between those two commits in libdohj seems to be that core/pom.xml changed, in the following commit:
That in turn moves the network.bisq.bitcoinj dependency for libdohj from commit 2033cc60 to 1fd8909a.
The only meaningful commit within that range for bitcoinj in turn is:
That in turn seems to empirically fix a bug in Bisq where transactions take a very long time to broadcast, which was present from v0.6.3 until current time. I and @ManfredKarrer debugged this issue and while we don't understand 100% why that code change resolves the issue, it does seem to workaround it, and I'm fine with the comments added in bisq-network/bitcoinj@1fd8909af3 to document the issue for future root cause fixes.
I will note that the other changes to our libraries seems to have been merged without prior review, which might not be ideal.
The current PR seems like it is updating the version used in libdohj as intended, and libdohj in turn wraps our fork of bitcoinj (for reasons I don't quite understand yet).
No description provided.