Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Webchain (WEB) #1779

Closed
wants to merge 4 commits into from
Closed

List Webchain (WEB) #1779

wants to merge 4 commits into from

Conversation

khaledalam
Copy link

@pahanzt
Copy link

pahanzt commented Oct 17, 2018

@ManfredKarrer hi, on behalf of Webchain team, I'd like to clarify, what's failing here exactly? @khaledalam (responsible developer) couldn't identify a problem. Please give a tip and tag him with an answer.

@ManfredKarrer
Copy link
Member

Ignore that, thats an issue on the build sytem and download at oracle...

@pahanzt
Copy link

pahanzt commented Oct 22, 2018

@ManfredKarrer thanks for response. is pull request going to be merged or are we still missing something?

@pahanzt
Copy link

pahanzt commented Nov 8, 2018

@ManfredKarrer hello, could you please help with our case? 17 days since our last request.

@ManfredKarrer
Copy link
Member

ManfredKarrer commented Nov 8, 2018

Assets are not my responsibility. We are short on dev resources and asset listing is not on the high priority list. See discussions with delisting inactive coins. > 90% of the coins are never traded anyway so we ahve to question if its worth for us to put so much effort on it.

@cbeams
Copy link
Member

cbeams commented Nov 9, 2018

@blabno reviews these PRs as he has time, but there are no guarantees. This PR does not follow instructions as it has multiple commits. Please re-read the instructions. Please also fix the merge error that now exists.

@blabno
Copy link

blabno commented Nov 15, 2018

@pahanzt please rebase against master and resolve conflicts.

@khaledalam
Copy link
Author

@blabno solved it.

@juice99
Copy link

juice99 commented Dec 1, 2018

@blabno @cbeams any news about merging it?

@khaledalam
Copy link
Author

@pahanzt please rebase against master and resolve conflicts.

@cbeams i rebased for the second time, it's ready now please check it.

@khaledalam
Copy link
Author

@blabno @cbeams ??

@blabno
Copy link

blabno commented Dec 19, 2018

You did not rebased but merged instead. You have to rebase. Your PR must be composed of just one commit.

@khaledalam khaledalam mentioned this pull request Dec 20, 2018
@khaledalam
Copy link
Author

@blabno @cbeams @ManfredKarrer all instructions followed here: #2176 , thanks for explanation

@blabno
Copy link

blabno commented Jan 7, 2019

unknown repository

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 7, 2019

Closing because of duplicate. #2176

@ripcurlx ripcurlx closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants