Verify dao param default vals #1769 #1824
Conversation
New, more intuitive methods for testing min and max values of proposed DAO parameters.
Unit tests also provided.
Next up will be a discussion of what limits the remaining parameters should have.
First part of issue: bisq-network#1769
New, more intuitive methods for testing min and max values of proposed DAO parameters.
Unit tests also provided.
Solves issue: bisq-network#1769
There was a problem hiding this comment.
I could not add the comment to the code directly...
I would prefer to not have class fieds in the test as that makes the test more complex. Would prefer also to keep the formatter out completely as its an injected object. The test cannot be run atm in the IDEA without extra setup (jvm args) as the mockit framework has issues with the recent java 10 update.... I know we have other tests as well where that is the case but I prefer that new tests are as functional style as possible (e.g. simple input simple output). The formatting can be done in the caller and that does not need to be tested.
In the test there are some unused fields, please remove those.
|
As discussed on Slack there have been bigger changes of the parameter handling so that is outdated. |
Basis code for DAO param validation