New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting ui fixes #2094

Merged
merged 3 commits into from Dec 8, 2018

Conversation

Projects
None yet
2 participants
@sqrrm
Copy link
Member

sqrrm commented Dec 8, 2018

No description provided.

sqrrm added some commits Dec 6, 2018

Fix issue with wrong vote icons when scrolling
JavaFX reuses the cells in a table as they're expensive to create. The
iconButton needs to be a temporary as it will otherwise update cells
with the button icon of another item when scrolling fast.

@sqrrm sqrrm requested review from ManfredKarrer and ripcurlx as code owners Dec 8, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

Great thanks for the fixes!

@ManfredKarrer ManfredKarrer merged commit 2e4b8ea into bisq-network:master Dec 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sqrrm sqrrm referenced this pull request Dec 29, 2018

Closed

For December 2018 #190

@BravoIndia BravoIndia referenced this pull request Dec 30, 2018

Closed

For December 2018 #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment