Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use percentage based value for security deposits #2498

Merged
merged 6 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Mar 5, 2019

Use percentage based value of trade amount for buyer and seller
security deposit.
To ensure that the BTC value is not getting too low, we apply a min.
value for both.

Use percentage based value for security deposits
Use percentage based value of trade amount for buyer and seller
security deposit.
To ensure that the BTC value is not getting too low, we apply a min.
value for both.

@ManfredKarrer ManfredKarrer requested a review from devinbileck Mar 5, 2019

ManfredKarrer and others added some commits Mar 5, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Mar 5, 2019

@ManfredKarrer I've added an informational icon tooltip and a new badge, as it is a big change that might lead to security deposit mistakes.

@ripcurlx
Copy link
Member

ripcurlx left a comment

ACK

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Mar 5, 2019

@ManfredKarrer I've added the news badge for the instant trade to this PR as I'm reusing the new NewBadge component.

@ManfredKarrer ManfredKarrer merged commit ac3cae1 into bisq-network:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:make-buyer-security-deposit-percentage-based branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.