Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handling during Tor setup #2538

Conversation

Projects
None yet
3 participants
@devinbileck
Copy link
Member

commented Mar 14, 2019

A recent change in the netlayer is now seeing exceptions wrapped in
a TorCtlException if an error occurs while setting up Tor.

So when an issue such as "Auth cookie not created" (#2398) occurs,
which was previously raised as an IOException, it was restarting Tor
rather than showing the error message to the user.

Fix exception handling during Tor setup
A recent change in the netlayer is now seeing exceptions wrapped in
a TorCtlException if an error occurs while setting up Tor.

So when an issue such as "Auth cookie not created" (#2398) occurs,
which was previously raised as an IOException, it was restarting Tor
rather than showing the error message to the user.

@devinbileck devinbileck requested a review from ManfredKarrer as a code owner Mar 14, 2019

@devinbileck

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@freimair can you confirm exceptions wrapped in a TorCtlException is the expected behaviour?

@ManfredKarrer ManfredKarrer requested review from freimair and removed request for ManfredKarrer Mar 14, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@freimair I leave the review to you.

@freimair
Copy link
Member

left a comment

ACK

Slowly cleaning up the netlayer stuff. Maybe I introduce some custom exceptions instead of wrapping all and everything in this dubious TorCtlException...

@ManfredKarrer ManfredKarrer merged commit a7dacbf into bisq-network:master Mar 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-handling-exception-during-tor-setup branch Mar 18, 2019

@devinbileck devinbileck referenced this pull request Mar 26, 2019

Closed

For March 2019 #244

@freimair freimair referenced this pull request Mar 31, 2019

Closed

For March 2019 #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.