For March 2019

[devinbileck]

Summary

• BSQ requested: 6550
• BSQ address: B1N7BFqBX2MUmbZ4KGNKujooPaWBxTyVx6H

Contributions delivered

• Testing (exploratory style). Primarily focused on DAO related functionality. I mainly encountered/entered UI issues or improvements, but did uncover a more serious issue when submitting proposals with manipulated DAO parameters, leading to Add irregular txType, add check for total balance, prevent proposal withhold attack bisq#2587. [3000 BSQ]

  • Show BTC amount required for issuance in compensation/reimbursement request confirmation prompt
  • Add visual indicator that a pending vote reveal transaction needs to be published in upcoming reveal phase
  • Remove salt for account age verification field when adding altcoin account
  • System tray icon on Linux does not use transparent background
  • Retain window size/location upon restarting application
  • Show the security deposit in the available offers view
  • UI improvements when DAO state in conflict

• Testing wallet restore functionality (after several reported issues). Identified issue Wallet shows 0 balance after restore seed words [1000 BSQ]

• Debugging the auth cookie not created issue on Windows. And provided a solution which lead to a fix being merged. [1000 BSQ]

• Implemented misc bug fixes and improvements. To desktop client. [1000 BSQ]

  • Show valuation in BTC balance tooltips
  • Update bond lockup prompt
  • Fix exception handling during Tor setup
  • Fix typos/grammar in account.seed.restore.info
  • Fix BTC status incorrectly hidden on splash screen
  • Suppress popup at shutdown when open offers are disabled
  • Update change param validator error messages
  • Show close button when creating offer without required account

• Reviewed PRs. [500 BSQ]

  • Add MacOS support in install_java.sh script
  • Fix incorrect available balance for voting
  • Add removed deprecated payment methods again as it would break trade history
  • Fix missing balance at restore from seed words
  • Add dao betatest network
  • Improve data structure, validation and performance
  • Fix get all bonds not returning not active bonds
  • Set max buyer's security deposit to 20% instead of 10%

BSQ amount requested: 6500

Contributions in progress

• Expanding manual test coverage. I am creating test cases in our new testing tool https://bisq.ontestpad.com. I have a basic structure implemented with test scenarios for various components of the Bisq desktop application. However, some scenarios are just placeholders and require additional details added, and there are several components that will need scenarios to be implemented. I am currently implementing the test scenarios using a BDD-style syntax (given/when/then). I will need user feedback if that is the best approach, given that not everyone that will be executing them has a testing/development background.

• Ongoing testing. Primarily focused on DAO related functionality in anticipation of the DAO launch.

• Deploying additional nodes. A relay node and price node.

Roles performed

• Bitcoin Node Operator: Bitcoin Node Operator roles#67 (comment) [50 BSQ]

BSQ amount requested: 50

Notes to self

Details

• My contributions were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/pulls?q=is%3Apr+is%3Amerged+author%3Adevinbileck+updated%3A2019-03-01..2019-03-31

• My PR reviews this month were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adevinbileck+updated%3A2019-03-01..2019-03-31+sort%3Aupdated-desc

• My issues discovered/entered were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Adevinbileck+created%3A2019-03-01..2019-03-31

[ripcurlx]

Closing as complete, see #243 (comment).