Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BTC status incorrectly hidden on splash screen #2567

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented Mar 21, 2019

Issue: When launching a new Bisq instance (i.e. new data directory) and
remaining on the user agreement screen for >90 seconds while reading it,
once you accept the agreement the BTC status was not being shown
on the splash screen.
image

Cause: showTorNetworkSettingsTimer gets triggered after 90 seconds
and since Tor is not started until after accepting the user agreement,
it was incorrectly assuming that Tor is not working and as a result
hiding the BTC status.

Fix: Don't hide the BTC status in showTorNetworkSettingsTimer.
image

If there is an issue with Tor, splashP2PNetworkErrorMsgListener handles
hiding the BTC status.
image

Fix BTC status incorrectly hidden on splash screen
Issue: When launching a new Bisq instance (i.e. new data directory) and
remaining on the user agreement screen for >90 seconds while reading it,
once you accept the agreement the BTC status was not being shown
on the splash screen.

Cause: showTorNetworkSettingsTimer gets triggered after 90 seconds
and since Tor is not started until after accepting the user agreement,
it was incorrectly assuming that Tor is not working and as a result
hiding the BTC status.

Fix: Don't hide the BTC status in showTorNetworkSettingsTimer. If there
is an issue with Tor, splashP2PNetworkErrorMsgListener handles
hiding the BTC status.
@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 0b1b89e into bisq-network:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-btc-status-incorrectly-hidden-on-splash-screen branch Mar 21, 2019

@devinbileck devinbileck referenced this pull request Mar 26, 2019

Closed

For March 2019 #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.