Fix BTC status incorrectly hidden on splash screen #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When launching a new Bisq instance (i.e. new data directory) and remaining on the user agreement screen for >90 seconds while reading it, once you accept the agreement the BTC status was not being shown on the splash screen. Cause: showTorNetworkSettingsTimer gets triggered after 90 seconds and since Tor is not started until after accepting the user agreement, it was incorrectly assuming that Tor is not working and as a result hiding the BTC status. Fix: Don't hide the BTC status in showTorNetworkSettingsTimer. If there is an issue with Tor, splashP2PNetworkErrorMsgListener handles hiding the BTC status.
devinbileck
deleted the
fix-btc-status-incorrectly-hidden-on-splash-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When launching a new Bisq instance (i.e. new data directory) and
remaining on the user agreement screen for >90 seconds while reading it,
once you accept the agreement the BTC status was not being shown
on the splash screen.
Cause: showTorNetworkSettingsTimer gets triggered after 90 seconds
and since Tor is not started until after accepting the user agreement,
it was incorrectly assuming that Tor is not working and as a result
hiding the BTC status.
Fix: Don't hide the BTC status in showTorNetworkSettingsTimer.
If there is an issue with Tor, splashP2PNetworkErrorMsgListener handles
hiding the BTC status.