-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add irregular txType, add check for total balance, prevent proposal withhold attack #2587
Add irregular txType, add check for total balance, prevent proposal withhold attack #2587
Commits on Mar 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c20964f - Browse repository at this point
Copy the full SHA c20964fView commit details -
Add IRREGULAR txType for txs which are not rule conform but not burnt
We don't want to burn BSQ in cases like that the tx was published too late, which is a valid case if the tx does not make it in the next block. We set such txs as IRREGULAR and allow spending of the BSQ, but there function in the governance is invalidated. We also add a check if the sum of all UTXO is the same as the sum of the genesis + sum of issuance txs - burned fees.
Configuration menu - View commit details
-
Copy full SHA for ce1da64 - Browse repository at this point
Copy the full SHA ce1da64View commit details -
Merge branch 'master' into add-check-for-bsq-balance
# Conflicts: # desktop/src/main/java/bisq/desktop/main/dao/wallet/dashboard/BsqDashboardView.java
Configuration menu - View commit details
-
Copy full SHA for ff86831 - Browse repository at this point
Copy the full SHA ff86831View commit details -
Update core/src/main/java/bisq/core/dao/governance/votereveal/VoteRev…
…ealService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for 3d5ff1c - Browse repository at this point
Copy the full SHA 3d5ff1cView commit details -
Update core/src/main/java/bisq/core/dao/governance/votereveal/VoteRev…
…ealService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for 83b7ed9 - Browse repository at this point
Copy the full SHA 83b7ed9View commit details -
Update core/src/main/java/bisq/core/dao/node/parser/TxParser.java
Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for a3e1e67 - Browse repository at this point
Copy the full SHA a3e1e67View commit details
Commits on Mar 27, 2019
-
Update desktop/src/main/java/bisq/desktop/main/dao/wallet/dashboard/B…
…sqDashboardView.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for 2758db5 - Browse repository at this point
Copy the full SHA 2758db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7479b88 - Browse repository at this point
Copy the full SHA 7479b88View commit details -
Merge branch 'add-check-for-bsq-balance' of https://github.com/Manfre…
…dKarrer/bisq into add-check-for-bsq-balance
Configuration menu - View commit details
-
Copy full SHA for 121c0f6 - Browse repository at this point
Copy the full SHA 121c0f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf83687 - Browse repository at this point
Copy the full SHA bf83687View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8016f45 - Browse repository at this point
Copy the full SHA 8016f45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 793d006 - Browse repository at this point
Copy the full SHA 793d006View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bd6f03 - Browse repository at this point
Copy the full SHA 1bd6f03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 999fe85 - Browse repository at this point
Copy the full SHA 999fe85View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa8b8c5 - Browse repository at this point
Copy the full SHA fa8b8c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1edc62 - Browse repository at this point
Copy the full SHA c1edc62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b0a17 - Browse repository at this point
Copy the full SHA 73b0a17View commit details -
Merge branch 'master' into add-check-for-bsq-balance
# Conflicts: # core/src/main/resources/i18n/displayStrings.properties # desktop/src/main/java/bisq/desktop/main/dao/wallet/dashboard/BsqDashboardView.java
Configuration menu - View commit details
-
Copy full SHA for c6947ba - Browse repository at this point
Copy the full SHA c6947baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8704ba9 - Browse repository at this point
Copy the full SHA 8704ba9View commit details -
Update core/src/main/java/bisq/core/dao/governance/param/Param.java
Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for af3aedb - Browse repository at this point
Copy the full SHA af3aedbView commit details -
Update core/src/main/java/bisq/core/dao/governance/param/Param.java
Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for f0787d8 - Browse repository at this point
Copy the full SHA f0787d8View commit details -
Update core/src/main/java/bisq/core/dao/governance/param/Param.java
Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for 9202d28 - Browse repository at this point
Copy the full SHA 9202d28View commit details
Commits on Mar 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 499d91e - Browse repository at this point
Copy the full SHA 499d91eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3ad4ea - Browse repository at this point
Copy the full SHA f3ad4eaView commit details -
Protect against proposal withhold attack
Set proposals which have been not included in the blind vote but which have been later published and are part if the cycles proposals to rejected. A malicious voter could manipulate the software to withhold publishing of his proposal and be the only voter on it. At the last block in the blind vote phase he could publish the proposal but others cannot vote anymore as they likely have already voted. In the vote result the other voters would have treated it like ignored and if the voter had enough BSQ to pass the quorum he could get accepted his proposal. With this change we set all proposals which are not part in the blind vote data but found in the cycle's ballot list as rejected.
Configuration menu - View commit details
-
Copy full SHA for 39ee4c0 - Browse repository at this point
Copy the full SHA 39ee4c0View commit details -
Update core/src/main/java/bisq/core/dao/governance/voteresult/VoteRes…
…ultService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for c3a8c27 - Browse repository at this point
Copy the full SHA c3a8c27View commit details -
Update core/src/main/java/bisq/core/dao/governance/voteresult/VoteRes…
…ultService.java Co-Authored-By: ManfredKarrer <mk@nucleo.io>
Configuration menu - View commit details
-
Copy full SHA for 24811ff - Browse repository at this point
Copy the full SHA 24811ffView commit details
Commits on Mar 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 695ed13 - Browse repository at this point
Copy the full SHA 695ed13View commit details -
Merge branch 'add-check-for-bsq-balance' of https://github.com/Manfre…
…dKarrer/bisq into add-check-for-bsq-balance
Configuration menu - View commit details
-
Copy full SHA for 96a20ae - Browse repository at this point
Copy the full SHA 96a20aeView commit details -
Merge branch 'master' into add-check-for-bsq-balance
# Conflicts: # core/src/main/resources/i18n/displayStrings.properties
Configuration menu - View commit details
-
Copy full SHA for 18a3f1e - Browse repository at this point
Copy the full SHA 18a3f1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for acf2648 - Browse repository at this point
Copy the full SHA acf2648View commit details -
Add random delay for proposalPayload publishing
We want to avoid that all nodes publish at the same time all proposals, so we add a random delay from 100 ms - 5 sec. A more sophisticated protection would be probably good but that delay should help to avoid network spikes and is simple enough to not add risks that the publishing would fail.
Configuration menu - View commit details
-
Copy full SHA for bb7ff47 - Browse repository at this point
Copy the full SHA bb7ff47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30059eb - Browse repository at this point
Copy the full SHA 30059ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 995844f - Browse repository at this point
Copy the full SHA 995844fView commit details
Commits on Mar 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a08b910 - Browse repository at this point
Copy the full SHA a08b910View commit details -
Configuration menu - View commit details
-
Copy full SHA for bec73dc - Browse repository at this point
Copy the full SHA bec73dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b11e58 - Browse repository at this point
Copy the full SHA 4b11e58View commit details -
- We add a filter to the getMeritStake method to avoid an exception at getWeightedMeritAmount which would set merits to 0 in case the issuance height blind would be larger than the vote height. I saw that error log but could not reproduce it afterwards. It basically protects that we do not add the issuance of the current cycle to the merit used in the blind vote of that cycle. - We add 1 block in the getCurrentlyAvailableMerit method to get the same merit value if the blind vote was included in the next block.
Configuration menu - View commit details
-
Copy full SHA for d5c7e0a - Browse repository at this point
Copy the full SHA d5c7e0aView commit details -
Use onParseBlockCompleteAfterBatchProcessing to avoid sequence issues
When using onParseBlockChainComplete and onParseBlockCompleteAfterBatchProcessing the onParseBlockCompleteAfterBatchProcessing is called earlier as onParseBlockChainComplete which caused incorrect state update in the UI.
Configuration menu - View commit details
-
Copy full SHA for a28805b - Browse repository at this point
Copy the full SHA a28805bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a71a573 - Browse repository at this point
Copy the full SHA a71a573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e6f0bf - Browse repository at this point
Copy the full SHA 1e6f0bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b39c8be - Browse repository at this point
Copy the full SHA b39c8beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2d9fe1 - Browse repository at this point
Copy the full SHA e2d9fe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69b134b - Browse repository at this point
Copy the full SHA 69b134bView commit details -
We did not update the merit correctly in case there was no proposal selected.
Configuration menu - View commit details
-
Copy full SHA for d422a73 - Browse repository at this point
Copy the full SHA d422a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 823cec0 - Browse repository at this point
Copy the full SHA 823cec0View commit details
Commits on Mar 31, 2019
-
Use burnedBsq field in Tx for burnedFee and invalidatedBsq
In case of an invalid tx we burn all available BSQ input. We only know that at parsing time. We renamed the burntFee field to burntBsq to make it more generic and use it for the burnt fee in case if a normal tx and as invalidatedBsq in case of an invalid tx.
Configuration menu - View commit details
-
Copy full SHA for d5fc7cb - Browse repository at this point
Copy the full SHA d5fc7cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe646e5 - Browse repository at this point
Copy the full SHA fe646e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e624625 - Browse repository at this point
Copy the full SHA e624625View commit details -
Configuration menu - View commit details
-
Copy full SHA for 122bc80 - Browse repository at this point
Copy the full SHA 122bc80View commit details -
- Check max length of strings and byte arrays - Check that tx ID has 64 chars - Add ExtraDataMapValidator for validating extraDataMap fields
Configuration menu - View commit details
-
Copy full SHA for 73db81a - Browse repository at this point
Copy the full SHA 73db81aView commit details -
Add BTC_DAO_TESTNET again to keep supporting current dao testnet
- It is more safe to separate the BTC_DAO_TESTNET and BTC_DAO_REGTEST by the network ID as that prevents on the P2P network layer that the network could interconnect. We would have risked that we receive network data from the other network as users would use the persisted peers for connections.
Configuration menu - View commit details
-
Copy full SHA for c7bd2ee - Browse repository at this point
Copy the full SHA c7bd2eeView commit details -
Merge branch 'master' into add-check-for-bsq-balance
# Conflicts: # core/src/main/resources/i18n/displayStrings_de.properties # core/src/main/resources/i18n/displayStrings_el.properties # core/src/main/resources/i18n/displayStrings_es.properties # core/src/main/resources/i18n/displayStrings_fa.properties # core/src/main/resources/i18n/displayStrings_fr.properties # core/src/main/resources/i18n/displayStrings_hu.properties # core/src/main/resources/i18n/displayStrings_pt.properties # core/src/main/resources/i18n/displayStrings_ro.properties # core/src/main/resources/i18n/displayStrings_ru.properties # core/src/main/resources/i18n/displayStrings_sr.properties # core/src/main/resources/i18n/displayStrings_th.properties # core/src/main/resources/i18n/displayStrings_vi.properties # core/src/main/resources/i18n/displayStrings_zh.properties
Configuration menu - View commit details
-
Copy full SHA for fa3ec34 - Browse repository at this point
Copy the full SHA fa3ec34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 431f76e - Browse repository at this point
Copy the full SHA 431f76eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e74ce12 - Browse repository at this point
Copy the full SHA e74ce12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a710f - Browse repository at this point
Copy the full SHA 30a710fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dad4b04 - Browse repository at this point
Copy the full SHA dad4b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d56ce9 - Browse repository at this point
Copy the full SHA 4d56ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9e4b49 - Browse repository at this point
Copy the full SHA e9e4b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2bb14 - Browse repository at this point
Copy the full SHA 0e2bb14View commit details -
Configuration menu - View commit details
-
Copy full SHA for f95f770 - Browse repository at this point
Copy the full SHA f95f770View commit details