Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use bisq's bitcoinj 0.15.1 #2772

Open
wants to merge 30 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@oscarguindzberg
Copy link
Contributor

commented Apr 23, 2019

No description provided.

@ManfredKarrer ManfredKarrer removed the request for review from cbeams Apr 23, 2019

@ManfredKarrer ManfredKarrer changed the title Use bisq's bitcoinj 0.15.1 [WIP] Use bisq's bitcoinj 0.15.1 Apr 23, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

I added WIP so that it does not get merged accidentally. I will not have time soon for review and it will require a solid review. We also need to deplay soon versions with the security improvements against the scammer and i prefer to not add a big change like that in that period. Sorry for that delay, looking forward to get it in but unfortunately a bit bad timing atm....

@nopara73

This comment has been minimized.

Copy link

commented Apr 24, 2019

I added WIP so that it does not get merged accidentally.

Just a heads up: GitHub added Draft PRs those prevent merging. (Although you cannot downgrade a PR to be Draft, you have to start out with that.)

@ripcurlx ripcurlx added the in:wallet label Apr 24, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Just a heads up: GitHub added Draft PRs those prevent merging. (Although you cannot downgrade a PR to be Draft, you have to start out with that.)

Thanks. We are using that once the PR maker knows that it cannot be merged soon. In that case @oscarguindzberg did not had the information about the current priority changes so I needed to add the WIP afterwards...

@ManfredKarrer
Copy link
Member

left a comment

utACK

I leave it to @ripcurlx when to merge as it require a profound test cycle for all wallet use cases and DAO tx use cases.

@ManfredKarrer ManfredKarrer changed the title [WIP] Use bisq's bitcoinj 0.15.1 Use bisq's bitcoinj 0.15.1 May 14, 2019

@devinbileck

This comment has been minimized.

Copy link
Member

commented May 19, 2019

I ran into the following error when launching a seednode (as a DAO full node) on regtest. It appears to be caused by updating to guava 27. We need to update btcd-cli4j to use guava 27 as well.

May-17 16:15:57.793 [RpcService] ERROR b.c.d.n.f.RpcService: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V 
java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.startMonitors(BtcdDaemonImpl.java:213)
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.<init>(BtcdDaemonImpl.java:53)
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:136)
    at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
    at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
    at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:844)
May-17 16:15:57.795 [SeedNodeMain] ERROR b.c.d.n.f.FullNode: An error occurred: Error=bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V 
bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:153)
    at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
    at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
    at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.startMonitors(BtcdDaemonImpl.java:213)
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.<init>(BtcdDaemonImpl.java:53)
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:136)
    ... 6 more
May-17 16:15:57.824 [SeedNodeMain] ERROR b.c.a.m.AppSetupWithP2PAndDAO: An error occurred: Error=bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
@oscarguindzberg

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

I just:

  • rebased from master
  • Excluded guava dependency from btcd-cli4j

Once bisq-network/btcd-cli4j#4 is merged I can update this pull request to use the latest btcd-cli4j version

@ripcurlx

This comment has been minimized.

Copy link
Member

commented May 30, 2019

I just:

  • rebased from master
  • Excluded guava dependency from btcd-cli4j

Once bisq-network/btcd-cli4j#4 is merged I can update this pull request to use the latest btcd-cli4j version

@oscarguindzberg  Do you want to update the PR with the latest btcd-cli4j version before the merge?

oscarguindzberg added some commits Apr 9, 2019

bitcoinj 0.15: Bip44 refactor.
- WalletConfig was rewritten from scratch based on bitcoinj 0.15 WalletAppKit.
- bitcoinj 0.15 allows bip32 custom paths by constructor parameters, some subclasses were removed.
bitcoinj 0.15: Futures.addCallback() in guava 27 requires an executor.
Using MoreExecutors.directExecutor() as it used to be the default behaviour with the executor-less method.

@oscarguindzberg oscarguindzberg force-pushed the oscarguindzberg:bitcoinj_0_15 branch from 3e1351b to 1a5cf2e May 30, 2019

@oscarguindzberg

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@ripcurlx Just updated the PR to use the latest btcd-cli4j. I also did a rebase from master

@devinbileck devinbileck referenced this pull request Jun 7, 2019

Closed

For Cycle 2 #295

@devinbileck devinbileck referenced this pull request Jul 8, 2019

Closed

For Cycle 3 #309

@ripcurlx ripcurlx changed the title Use bisq's bitcoinj 0.15.1 [WIP] Use bisq's bitcoinj 0.15.1 Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.