For Cycle 3

[devinbileck]

Summary

This compensation request covers work delivered since the previous voting period (for cycle 2) up until a few days prior to the end of the cycle 3 proposal phase, between 2019-06-08 and 2019-07-08.

Since the BSQ market is still new and undergoing price discovery, this request still assumes 1 BSQ == 1 USD.

• BSQ requested: 1475
• DAO proposal transaction: https://explorer.bisq.network/tx.html?tx=d99c3ce06db0ad0bb7851c88bca2dfc8bb4d19179d6f58552a1851e1dd92d68d

Contributions delivered

• Setup testnet seed node. I deployed a seed node on testnet since the old testnet seed nodes are no longer maintained and testnet is still a useful testing environment. However, since I am not an arbitrator and do not have a registered key, in order to utilize it you need to use --useDevPrivilegeKeys=true. But that means anyone can register as an arbitrator. I have contemplated adding my own key just for testnet to prevent that, but am undecided if I should. [200 BSQ]
  Resurrect testnet bisq#2920

Note: Compensation for setup of the node is valued at 200 BSQ as per the following:
https://docs.bisq.network/exchange/howto/run-seednode.html#payment

• Implemented a shell script to quickly and easily generate BSQ genesis transaction on either testnet or regtest. As part of setting up a seed node on testnet and in the process of learning how to create the BSQ genesis transaction and struggling to do it using the Bitcoin core wallet, I created a shell script that can be used to quickly and easily generate one on either testnet or regtest. This should be beneficial for testing purposes. [200 BSQ]
  https://github.com/bisq-network/bisq/pull/2920/files#diff-6612c2e477cc0dcc354e5637a35dc426

• Code contributions. [200 BSQ]

  • Update BitcoinJ checkpoint files
  • Fix AckMessage failure

• Reviewed PRs. [500 BSQ]

  • Update idea-import.md
  • Use tempTradingPeerNodeAddress if the trade doesn't have a trading peer set yet
  • Wait for initialized wallet before processing dispute msgs, fix #2914
  • Increase tolerated trade limit from 0.01 BTC to 0.02 BTC
  • Late vote reveal handling
  • Limit BSQ validator to 10M BSQ, fix #2727
  • Add instructions for paying asset listing fee
  • Change stats page graph subtitles

BSQ amount requested: 1100

Contributions in progress

• Investigating dependency checker. I started investigating integrating a dependency checker for known vulnerabilities with third party libraries. There are a few solutions/approaches such as a GitHub extension (e.g. https://github.com/marketplace/dependabot-preview), or integrating it into the Gradle build process (e.g. https://github.com/jeremylong/DependencyCheck). Since the GitHub extension seems a bit too happy to update to anything new, DependencyCheck may be more reasonable for what we're doing. I ran the DependencyCheck and it flagged a lot of modules. It will be tedious to review and see which are applicable and which to ignore.

• Testing BitcoinJ 0.15. I have started testing the PR that integrates BitcoinJ 0.15, and my current test results/progress is detailed in TestPad. This is still an ongoing task as I have not had much time lately to devote to this.

• Expanding manual test coverage. I have been creating test cases in our new testing tool https://bisq.ontestpad.com. I have a basic structure implemented with test scenarios for various components of the Bisq desktop application. However, some scenarios are just placeholders and require additional details added, and there are several components that will need scenarios to be implemented. Once the majority of the scenarios are implemented and the placeholders completed, I will request compensation for this.

Roles performed

• Bitcoin node operator: Bitcoin Node Operator roles#67 (comment) [75 BSQ]
• Seed node operator: Seednode Operator roles#15 (comment) [200 BSQ]
• Pricenode operator: Pricenode Operator roles#14 (comment) [50 BSQ]
• Relay operator for mobile notifications: Relay operator for mobile notifications roles#82 (comment) [50 BSQ]

Note: I am requesting 75 BSQ for each node which have additional requirements (e.g. storage, CPU, RAM) and 50 BSQ otherwise.

BSQ amount requested: 375

Notes to self

Details

• My contributions were determined by reviewing the results of these GitHub search queries:
  https://github.com/bisq-network/bisq/pulls?q=is%3Apr+is%3Amerged+author%3Adevinbileck+updated%3A2019-06-08..2019-07-08
  https://github.com/bisq-network/bisq-website/pulls?q=is%3Apr+is%3Amerged+author%3Adevinbileck+updated%3A2019-06-08..2019-07-08
  https://github.com/bisq-network/bisq-docs/pulls?q=is%3Apr+is%3Amerged+author%3Adevinbileck+updated%3A2019-06-08..2019-07-08

• My PR reviews this month were determined by reviewing the results of these GitHub search queries:
  https://github.com/bisq-network/bisq/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adevinbileck+updated%3A2019-06-08..2019-07-08+sort%3Aupdated-desc
  https://github.com/bisq-network/bisq-website/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adevinbileck+updated%3A2019-06-08..2019-07-08+sort%3Aupdated-desc
  https://github.com/bisq-network/bisq-docs/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adevinbileck+updated%3A2019-06-08..2019-07-08+sort%3Aupdated-desc

• My issues discovered/entered were determined by reviewing the results of these GitHub search queries:
  https://github.com/bisq-network/bisq/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Adevinbileck+created%3A2019-06-08..2019-07-08
  https://github.com/bisq-network/bisq-website/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Adevinbileck+created%3A2019-06-08..2019-07-08
  https://github.com/bisq-network/bisq-docs/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Adevinbileck+created%3A2019-06-08..2019-07-08