Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getBlocks issue #2821

Merged
merged 3 commits into from May 12, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented May 11, 2019

We disconnected seed nodes of we exceeded our connectionlimit which caused that getBlockResponses where not received. This PR fixes that.

ManfredKarrer added some commits May 11, 2019

Fix issue with too early disconnect to seeds
As soon we are over our connection target we start disconnecting seed
nodes though that can be too early as getBlocks requests are still
pending. We delay the disconnect seed handling to 3 minutes after our
first connection so give it enough time to receive the getBlocksResponse.
Call setAllowDisconnectSeedNodes from LiteNode after blocks received
Instead of the 3 minutes delay we set the flag from the lite node once
the blocks are received. We delay 20 seconds to allow multiple getBlocksRequests
to finish.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner May 11, 2019

@ManfredKarrer ManfredKarrer requested review from sqrrm and freimair May 11, 2019

@ManfredKarrer ManfredKarrer added this to the v1.2.0 milestone May 11, 2019

@ManfredKarrer ManfredKarrer requested a review from devinbileck May 11, 2019

@devinbileck
Copy link
Member

left a comment

ACK
Without this fix, I tested rebuilding the DAO state on mainnet and encountered the issue where I lost connection to all seednodes and was stuck synchronizing. I then tested again with this fix and it did not disconnect from the seeds and it successfully resynced the DAO state.

@ManfredKarrer ManfredKarrer merged commit f931ec8 into bisq-network:master May 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:fix-connection-issue branch May 30, 2019

@devinbileck devinbileck referenced this pull request Jun 7, 2019

Closed

For Cycle 2 #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.