Reputation BSQ added to BSQ Wallet screen #3366

niyid · 2019-10-06T17:48:59Z

Issue #3352 resolved.

chimp1984

NACK - if my interpretation is correct.

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java

freimair

I am not happy with the term "Reputation/Weight Balance". I myself (as an active bisq dev) do not understand what the value is about. Furthermore, one might misunderstand this value for riches available.

A few additional words that might clear things up:

"base balance"
"base merit"
"base vote weight"
"base vote weight (without stake)"
"for future voting cycles"
"for next voting cycle"

and we should align the wording here https://docs.bisq.network/dao/overview.html#reputation-based-voting

@m52go may we have your opinion

niyid · 2019-11-01T21:10:05Z

I am not happy with the term "Reputation/Weight Balance". I myself (as an active bisq dev) do not understand what the value is about. Furthermore, one might misunderstand this value for riches available.

A few additional words that might clear things up:

"base balance"

"base merit"

"base vote weight"

"base vote weight (without stake)"

"for future voting cycles"

"for next voting cycle"

and we should align the wording here https://docs.bisq.network/dao/overview.html#reputation-based-voting

@m52go may we have your opinion

OK. I am still waiting on the consensus on what term to use. @m52go @freimair

I think we should involve much more people on this discussion.

m52go · 2019-11-04T15:08:35Z

How about something like:

"Reputation Value (not spendable)"

OR

"Reputation Value (more details 🔗)"

If it's possible, I think the second option with a link to the current doc is better. There, this value is called "reputation value" and explains what it is and how it works.

I agree with freimair that calling this quantity a balance is confusing, because it's not spendable.

niyid · 2019-11-04T15:20:40Z

How about something like:

"Reputation Value (not spendable)"

OR

"Reputation Value (more details )"

If it's possible, I think the second option with a link to the current doc is better. There, this value is called "reputation value" and explains what it is and how it works.

I agree with freimair that calling this quantity a balance is confusing, because it's not spendable.

In that case, Reputation should suffice (removing the Balance appendage). Only problem is, @chimp1984 already pointed out that the docs are outdated.

Please refer to the related #3352.

m52go · 2019-11-04T15:52:32Z

Oh ok, I didn't see that conversation. The doc I referred to is the most up-to-date one, so I guess that needs to be updated.

As for my suggestions, simply replace "Reputation" with "Merit".

niyid · 2019-11-04T22:50:08Z

Oh ok, I didn't see that conversation. The doc I referred to is the most up-to-date one, so I guess that needs to be updated.

As for my suggestions, simply replace "Reputation" with "Merit".

I already have it as this:

dao.reputationBalance=Merit BSQ

@freimair is this OK with you?

Once again, please refer to related issue #3352 and the suggestion by @chimp1984.

m52go · 2019-11-04T23:06:44Z

I already have it as this:

dao.reputationBalance=Merit BSQ

I'm still seeing this dao.reputationBalance=Reputation/Weight Balance in the PR code.

In any case, I would strongly recommend adding some clarification text in parenthesis as suggested above. Either explicitly say it's not spendable or link to more information.

Concretely:

"Merit Value (not spendable)"

OR

"Merit Value (more details 🔗)"

sqrrm

NACK

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java

desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java

niyid · 2019-11-05T17:25:48Z

@sqrrm All fixed. Thanks.

…

On Tue, Nov 5, 2019 at 4:50 PM sqrrm ***@***.***> wrote: ***@***.**** requested changes on this pull request. NACK ------------------------------ In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java <#3366 (comment)>: > @@ -62,10 +72,11 @@ @Inject private BsqBalanceUtil(BsqWalletService bsqWalletService, DaoStateService daoStateService, - BsqFormatter bsqFormatter) { + BsqFormatter bsqFormatter, MyBlindVoteListService myBlindVoteListService) { Please follow local formatting, either line break at each argument or fit as many arguments as possible before line break. ------------------------------ In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java <#3366 (comment)>: > @@ -18,11 +18,14 @@ package bisq.desktop.main.dao.wallet; import bisq.desktop.components.TitledGroupBg; +import bisq.desktop.main.dao.wallet.tx.BsqTxListItem; Remove unused imports ------------------------------ In desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java <#3366 (comment)>: > @@ -42,7 +42,7 @@ @slf4j @EqualsAndHashCode(callSuper = true) @DaTa -class BsqTxListItem extends TxConfidenceListItem { +public class BsqTxListItem extends TxConfidenceListItem { Don't change access for no reason — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3366?email_source=notifications&email_token=AE2MWR5FH4VPFG7KB2OI4GTQSGI4ZA5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKKZ5AI#pullrequestreview-311795329>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2MWR4KQ4GPOSDJBZJ7BFDQSGI4ZANCNFSM4I5476XQ> .

freimair

Ack. We should squash this contribution because there is quite a lot of commits and merges and stuff.

@niyid stuff we observed with your contributions:

please keep the commit history clean (make yourself familiar with eg. git rebase --onto, git add -p
please stick to the given code style (in intellij idea: Menu [Code]->[Reformat Code])
please only commit stuff that has something to do with the topic of the PR (no import, field definition reorgs, ...)

niyid · 2019-11-09T17:14:03Z

Ack. We should squash this contribution because there is quite a lot of commits and merges and stuff.

@niyid stuff we observed with your contributions:

please keep the commit history clean (make yourself familiar with eg. git rebase --onto, git add -p

please stick to the given code style (in intellij idea: Menu [Code]->[Reformat Code])

please only commit stuff that has something to do with the topic of the PR (no import, field definition reorgs, ...)

Noted. Thanks.

I have squashed the commits.

sqrrm

utACK

Still need ack from @ManfredKarrer for changes in DAO code to be able to merge

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java

chimp1984 · 2019-11-14T00:01:08Z

Still need ack from @ManfredKarrer for changes in DAO code to be able to merge

This only applies to code in the dao package in core not in Desktop.

niyid · 2019-11-14T00:24:27Z

Thanks for your clarification. I was a bit confused as I did not touch any DAO code. Regards.

…

On Thu, 14 Nov 2019, 01:01 chimp1984, ***@***.***> wrote: Still need ack from @ManfredKarrer <https://github.com/ManfredKarrer> for changes in DAO code to be able to merge This only applies to code in the dao package in core not in Desktop. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3366?email_source=notifications&email_token=AE2MWR7NICICSB2KEDUJNBDQTSINDA5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEADGBY#issuecomment-553661191>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2MWRY7V62LZVDKFO7H76TQTSINDANCNFSM4I5476XQ> .

ripcurlx · 2019-11-14T14:41:10Z

@niyid could you please address the comment from @sqrrm. If that is changed ACK from my side as well, besides the fact that you still need to sign all your commits 😉

ripcurlx · 2019-11-14T14:43:39Z

Maybe the easiest thing would be to squash your commits into one as the last ones also doesn't fulfill https://chris.beams.io/posts/git-commit.

niyid · 2019-11-14T15:25:42Z

@niyid could you please address the comment from @sqrrm. If that is changed ACK from my side as well, besides the fact that you still need to sign all your commits

Final commit

ripcurlx · 2019-11-14T16:00:11Z

I'm talking about all commits in this PR. Otherwise GitHub will prevent it getting merged.

ripcurlx

NACK - the formatting in BsqBalanceUtil line 132 is not correct. Please use our formatting rules and also it would be great if you could just fork the bisq repository regularly and allow edits by maintainers. If it would have been like that I'd push the formatting fix myself.

freimair

Ack

ripcurlx

NACK - please see my comments

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java

ripcurlx

ACK

niyid requested review from ripcurlx and sqrrm as code owners October 6, 2019 17:48

chimp1984 suggested changes Oct 7, 2019

View reviewed changes

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java Outdated Show resolved Hide resolved

freimair suggested changes Nov 1, 2019

View reviewed changes

sqrrm requested changes Nov 5, 2019

View reviewed changes

niyid requested review from sqrrm and freimair November 6, 2019 08:12

freimair previously approved these changes Nov 9, 2019

View reviewed changes

freimair mentioned this pull request Nov 9, 2019

For Cycle 7 bisq-network/compensation#392

Closed

sqrrm previously approved these changes Nov 11, 2019

View reviewed changes

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java Outdated Show resolved Hide resolved

niyid mentioned this pull request Nov 13, 2019

For Cycle 7 (Deferred) bisq-network/compensation#409

Closed

niyid dismissed stale reviews from sqrrm and freimair via 42a732f November 14, 2019 16:14

BSQ Merit now displayed - fixes issue #3352

fb073c7

ripcurlx suggested changes Nov 18, 2019

View reviewed changes

freimair previously approved these changes Nov 19, 2019

View reviewed changes

ripcurlx suggested changes Nov 19, 2019

View reviewed changes

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java Outdated Show resolved Hide resolved

desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java Outdated Show resolved Hide resolved

niyid added 2 commits November 19, 2019 15:15

Broke merit text setting to 2 lines.

0711947

Fix formatting

8cfe221

niyid dismissed freimair’s stale review via f508b8c November 19, 2019 14:19

ripcurlx approved these changes Nov 26, 2019

View reviewed changes

ripcurlx merged commit 06f0d6b into bisq-network:master Nov 26, 2019

ripcurlx mentioned this pull request Dec 13, 2019

For Cycle 8 bisq-network/compensation#439

Closed

chimp1984 mentioned this pull request Jan 9, 2020

For Cycle 9 bisq-network/compensation#455

Closed

ripcurlx mentioned this pull request Feb 10, 2020

For Cycle 10 bisq-network/compensation#485

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reputation BSQ added to BSQ Wallet screen #3366

Reputation BSQ added to BSQ Wallet screen #3366

niyid commented Oct 6, 2019 •

edited by freimair

Loading

chimp1984 left a comment

freimair left a comment

niyid commented Nov 1, 2019 •

edited

Loading

m52go commented Nov 4, 2019

niyid commented Nov 4, 2019 •

edited

Loading

m52go commented Nov 4, 2019

niyid commented Nov 4, 2019 •

edited

Loading

m52go commented Nov 4, 2019

sqrrm left a comment

niyid commented Nov 5, 2019 via email

freimair left a comment

niyid commented Nov 9, 2019 •

edited

Loading

sqrrm left a comment

chimp1984 commented Nov 14, 2019

niyid commented Nov 14, 2019 via email

ripcurlx commented Nov 14, 2019 •

edited

Loading

ripcurlx commented Nov 14, 2019

niyid commented Nov 14, 2019 •

edited

Loading

ripcurlx commented Nov 14, 2019

ripcurlx left a comment •

edited

Loading

freimair left a comment

ripcurlx left a comment

ripcurlx left a comment

Reputation BSQ added to BSQ Wallet screen #3366

Reputation BSQ added to BSQ Wallet screen #3366

Conversation

niyid commented Oct 6, 2019 • edited by freimair Loading

chimp1984 left a comment

Choose a reason for hiding this comment

freimair left a comment

Choose a reason for hiding this comment

niyid commented Nov 1, 2019 • edited Loading

m52go commented Nov 4, 2019

niyid commented Nov 4, 2019 • edited Loading

m52go commented Nov 4, 2019

niyid commented Nov 4, 2019 • edited Loading

m52go commented Nov 4, 2019

sqrrm left a comment

Choose a reason for hiding this comment

niyid commented Nov 5, 2019 via email

freimair left a comment

Choose a reason for hiding this comment

niyid commented Nov 9, 2019 • edited Loading

sqrrm left a comment

Choose a reason for hiding this comment

chimp1984 commented Nov 14, 2019

niyid commented Nov 14, 2019 via email

ripcurlx commented Nov 14, 2019 • edited Loading

ripcurlx commented Nov 14, 2019

niyid commented Nov 14, 2019 • edited Loading

ripcurlx commented Nov 14, 2019

ripcurlx left a comment • edited Loading

Choose a reason for hiding this comment

freimair left a comment

Choose a reason for hiding this comment

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx left a comment

Choose a reason for hiding this comment

niyid commented Oct 6, 2019 •

edited by freimair

Loading

niyid commented Nov 1, 2019 •

edited

Loading

niyid commented Nov 4, 2019 •

edited

Loading

niyid commented Nov 4, 2019 •

edited

Loading

niyid commented Nov 9, 2019 •

edited

Loading

ripcurlx commented Nov 14, 2019 •

edited

Loading

niyid commented Nov 14, 2019 •

edited

Loading

ripcurlx left a comment •

edited

Loading