Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort existing gradle-witness.gradle #3585

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

blabno
Copy link

@blabno blabno commented Nov 9, 2019

This should make comparison in future much easier.

@freimair
Copy link
Member

freimair commented Nov 9, 2019

I would love to see that in action! Thanks for showing that up!

However, I suggest we implement signalapp/gradle-witness#34 ourselves, as the original seems to be unmaintained for quite some time and we have our own fork anyhow.

As for the implementation part, I already did bisq-network/gradle-witness#2.

For going forward, I suggest we get the implementation merged, and then add the resulting gradle-witness.jar in this PR and be done with it.

@blabno
Copy link
Author

blabno commented Nov 10, 2019

@freimair I think your fix is better. But this PR also does sort the current contents of the file so it's a good start.

@freimair
Copy link
Member

@blabno, Chris has merged the changes in the gradle-witness repo. Would you build the new gradle-witness.jar and include the binary in this PR so we can get this merged?

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Could you please address #3585 (comment)?

This should make comparison in future much easier.
@blabno
Copy link
Author

blabno commented Nov 19, 2019

@ripcurlx @freimair new included.

Copy link
Member

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. gradle-witness.jar checksum matches, library checksums did not change.

@freimair freimair dismissed ripcurlx’s stale review November 20, 2019 09:37

PR creator addressed the changes.

@freimair freimair merged commit f6740d0 into bisq-network:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants