Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0 #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa, all of Bisq's shadowJar tasks started failing Gradle's incremental build checks. This meant that repeated invocations of `gradle build` went from a handful of seconds to more than a minute, because shadowJar tasks had to be re-executed on every build. For example, with --info enabled, one would see entries like this in the build output: > Task :seednode:shadowJar Custom actions are attached to task ':seednode:shadowJar'. Caching disabled for task ':seednode:shadowJar' because: Caching has not been enabled for the task Task ':seednode:shadowJar' is not up-to-date because: Output property 'archiveFile' file [...]libs/seednode.jar has changed. This problem was solved by in GradleUp/shadow#524 and made available in the project's recent 5.0.2 release. This patch simply bumps the shadow plugin version to that value, and gets us back to snappy incremental builds, e.g.: $ gradle build BUILD SUCCESSFUL in 7s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa,
all of Bisq's shadowJar tasks started failing Gradle's incremental build
checks. This meant that repeated invocations of
gradle buildwent froma handful of seconds to more than a minute, because shadowJar tasks had
to be re-executed on every build.
For example, with --info enabled, one would see entries like this in the
build output:
This problem was solved by in GradleUp/shadow#524 and made
available in the project's recent 5.0.2 release. This patch simply bumps
the shadow plugin version to that value, and gets us back to snappy
incremental builds, e.g.: