Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0 #3635

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@cbeams
Copy link
Member

cbeams commented Nov 19, 2019

After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa,
all of Bisq's shadowJar tasks started failing Gradle's incremental build
checks. This meant that repeated invocations of gradle build went from
a handful of seconds to more than a minute, because shadowJar tasks had
to be re-executed on every build.

For example, with --info enabled, one would see entries like this in the
build output:

> Task :seednode:shadowJar
Custom actions are attached to task ':seednode:shadowJar'.
Caching disabled for task ':seednode:shadowJar' because:
  Caching has not been enabled for the task
Task ':seednode:shadowJar' is not up-to-date because:
  Output property 'archiveFile' file [...]libs/seednode.jar has changed.

This problem was solved by in johnrengelman/shadow#524 and made
available in the project's recent 5.0.2 release. This patch simply bumps
the shadow plugin version to that value, and gets us back to snappy
incremental builds, e.g.:

$ gradle build

BUILD SUCCESSFUL in 7s
After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa,
all of Bisq's shadowJar tasks started failing Gradle's incremental build
checks. This meant that repeated invocations of `gradle build` went from
a handful of seconds to more than a minute, because shadowJar tasks had
to be re-executed on every build.

For example, with --info enabled, one would see entries like this in the
build output:

    > Task :seednode:shadowJar
    Custom actions are attached to task ':seednode:shadowJar'.
    Caching disabled for task ':seednode:shadowJar' because:
      Caching has not been enabled for the task
    Task ':seednode:shadowJar' is not up-to-date because:
      Output property 'archiveFile' file [...]libs/seednode.jar has changed.

This problem was solved by in johnrengelman/shadow#524 and made
available in the project's recent 5.0.2 release. This patch simply bumps
the shadow plugin version to that value, and gets us back to snappy
incremental builds, e.g.:

    $ gradle build

    BUILD SUCCESSFUL in 7s
Copy link
Member

devinbileck left a comment

ACK

Copy link
Member

ripcurlx left a comment

ACK - thanks for pointing that out @cbeam! There is always something to learn in our build process 😄

@ripcurlx ripcurlx merged commit 928b35c into bisq-network:master Nov 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck mentioned this pull request Dec 13, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.