Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Not allow bitcoinj to auto connect to localhost when localhost was not detected by client #3783
This fixes the problem if the local bitcoin core node is not detected by our client,
As this is a bug based on the default localhost connect behavior of bitcoinj it is difficult to simulate on regtest.
…t detected by client This fixes the problem if the local bitcoin core node is not detected by our client, but bitcoinj is able to connect to it because of the auto connect to localhost behavior. In that case the minimum required nodes to broadcast a transaction will be 4 (provided nodes settings), but bitcoinj will only connect to one node. The requirement of 4 nodes will be never fulfilled and the transaction never broadcasted.
Should solve the problem also if you have a transaction already in limbo. Unfortunately for me it wasn't solved with a restart and after a SPV resync the transaction was removed by bitcoinj.
I don't think this is something new, so I think it should be fine to ship it in the next release.
I think that happens only in edge cases. At startup we connect to localhost (