Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report feature for disputes #3790

Merged

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 14, 2019

At the dispute views (mediator, refund agent both for trader and
dispute agents) the shortcut cmd+k (or crtl+k or alt+k) will open a
popup displaying all disputes as compact summary. A copy to clipboard
button make it easy to copy the text to a text editor and post the
relevant disputes for the mediators/refund agents report.

Fixes #3788

At the dispute views (mediator, refund agent both for trader and
dispute agents) the shortcut cmd+k (or crtl+k or alt+k) will open a
popup displaying all disputes as compact summary. A copy to clipboard
button make it easy to copy the text to a text editor and post the
relevant disputes for the mediators/refund agents report.
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Dec 14, 2019
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

chimp1984 commented Dec 14, 2019

Here is a example of the report format:

Dispute nr. 1
Opening date: 25 Nov 2019 11:52:08
Close date: 26 Nov 2019 12:04:54
Duration: 23 hours, 58 minutes
Summary notes: Buyer did not start payment.
Summary notes (trader 2): Buyer did not pay. Seller will get buyer's security deposit.
Reason: PROTOCOL_VIOLATION

Dispute nr. 2
Opening date: 12 Dec 2019 23:07:21
Close date: 13 Dec 2019 21:08:03
Duration: 22 hours, 58 minutes
Summary notes: Deposit tx was not published
Reason: BUG

Summary of reasons for disputes:
PROTOCOL_VIOLATION: 1
BUG: 1

I did not include trade ID for privacy reasons, but that's up for discussion if that should be added.

The summary notes are usually the same but the mediator/refund agent can send different summary notes as well. Only in that case we show both ("Summary notes (trader 2)").

@chimp1984 chimp1984 mentioned this pull request Dec 14, 2019
Copy link
Member

ripcurlx left a comment

ACK

Although it might not be super intuitive that the clipboard contains everything and only the UI shows the truncated version, I think it is good enough for a start.
Bildschirmfoto 2019-12-16 um 15 36 22

@ripcurlx ripcurlx merged commit 3e378b9 into bisq-network:master Dec 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

chimp1984 commented Dec 16, 2019

Although it might not be super intuitive that the clipboard contains everything and only the UI shows the truncated version, I think it is good enough for a start.

Its only for mediators...

@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 17, 2019
@chimp1984 chimp1984 deleted the chimp1984:add-report-feature-for-disputes branch Dec 22, 2019
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.