Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to seednode service / install scripts #3882

Merged
merged 9 commits into from Jan 29, 2020
Merged

Various improvements to seednode service / install scripts #3882

merged 9 commits into from Jan 29, 2020

Conversation

wiz
Copy link
Member

@wiz wiz commented Jan 9, 2020 •
edited

  • Add setting in seednode configuration to specify btcnode host/port
  • Tweak seednode torrc configuration options to improve P2P connectivity
  • Require bitcoin.service from bisq-seednode.service via systemd binding
  • Make seednode installer run from master and build bisq from release tag
  • Seednode must be shutdown using kill -9 until Bisq does not handle SIGTERM properly #3884 is fixed
  • Fix seednode uninstall script to use correct service names

@wiz wiz mentioned this pull request Jan 14, 2020
Closed
@wiz wiz force-pushed the improve-seednode-service-installer branch 4 times, most recently from 84bbe28 to 07ca406 Compare January 25, 2020 01:21
@wiz wiz force-pushed the improve-seednode-service-installer branch from 2b6f988 to c6401b5 Compare January 25, 2020 03:12
@wiz wiz force-pushed the improve-seednode-service-installer branch from e789a77 to 9c38a73 Compare January 25, 2020 03:31
@wiz
Copy link
Member Author

wiz commented Jan 25, 2020

Tested OK on Ubuntu 18.04 LTS

@wiz wiz marked this pull request as ready for review January 25, 2020 04:05
@wiz wiz requested a review from ripcurlx as a code owner January 25, 2020 04:05
@wiz wiz requested a review from sqrrm January 25, 2020 04:07
ripcurlx
ripcurlx reviewed Jan 27, 2020
View reviewed changes
seednode/torrc Outdated Show resolved Hide resolved
ripcurlx
ripcurlx approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 02e7448 into bisq-network:master Jan 29, 2020
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 29, 2020
@wiz wiz deleted the improve-seednode-service-installer branch February 6, 2020 10:27
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wiz @ripcurlx