Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 10 #493

Closed
ripcurlx opened this issue Feb 13, 2020 · 7 comments
Closed

For Cycle 10 #493

ripcurlx opened this issue Feb 13, 2020 · 7 comments
Assignees
@cbeams @sqrrm
Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Requests Compensation Request Board
Milestone
Cycle 10

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 13, 2020 •
edited
Loading

Summary

  • BSQ requested:10676 (7153 USD @ 0,67 USD/BSQ)

This is a compensation request for contributions delivered from last cycle until now (Feb 13). I calculated the amount based on the new three months average of 0,67 USD for 1 BSQ mentioned in #475.

Contributions delivered

Reviews

For this cycle I started to monitor review efforts for each PR separately to make it easier for others to estimate their on PR review efforts and to show the additional costs of different contributions. A high amount for a PR is either a sign of its complexity or shows the lack of quality by accumulated re-reviews over time.

Reviewed PRs:

View all reviewed PRs (33)

My PR reviews this month were created by reviewing the results of this GitHub Issues search query:
is:pr reviewed-by:ripcurlx updated:2020-01-14..2020-02-13 sort:updated-desc

Here it becomes already obvious that there is lots of room for savings as the biggest cost drivers are PRs with lack of quality. This has been addressed already partially by configuring Codacy PR quality checks, but will be an ongoing effort.

Following PRs Review efforts are either so small or haven't been tracked already for this cycle report separately:

Total USD amount for this remaining PRs: 630

USD amount requested: 1414

Development

I was working mainly on the v1.2.6 (and just right now on v1.2.7) release and following PRs were merged to master.

My merged PRs this month were created by reviewing the results of this GitHub Issues search query:
is:pr author:ripcurlx is:merged merged:2020-01-14..2020-02-13 sort:updated-desc

USD amount requested: 2160

Following PRs are covered by other role efforts already or are minor.

Testing

Besides the tests documented on Testpad, I had to do additional testing and binary/jar building caused by following issue bisq-network/bisq#3966. I did some additional smoke testing during the release process.

USD amount requested: 400

Release

To improve transparency I'll add the release efforts now separately and not combined with the Bisq Desktop Maintainer role anymore. Documentation of the release process can be found here.

Release preparations for v1.2.6 were a little bit tricky this time as we wanted to ship the depositTxId removal in this release. As during release testing we saw that it might cause too much load for the network we decided to postpone it to v1.2.8 together with a bigger privacy improvement which will need a forced update. As we didn't expected so many Bisq users running from master we have already some privacy enhanced trades in our data store that needed to be handled properly in this release as well (note: number of trades is different in v1.2.5- compared to v1.2.6+ because of this). The release needed to be delayed for one day as I wasn't able to start the Windows binary because of bisq-network/bisq#3966. Additionally we found this bug after the release which required a hotfix release on the same day.

USD amount requested: 1380

Support

Monitoring the support channel during my L2 times and am investigation atm one issue where funds are still locked up although trades were completed successfully.
Helping out L1 support whenever needed. Will track single L2 support requests in more detail in cycle 11.

USD amount requested: 420

Contributions in progress

I'm focusing right now on v1.2.8 and continue to get the PR workflow more streamlined.
Besides that I'm looking into USDT integration and am evaluating the current state of the account signing roll-out.

All efforts for my role as dev team lead (roughly occupied ~40% of my time) won't be put up for compensation until it is proven to have the success we are looking for.

Roles performed

USD amount requested for all these roles (see detailed amount for each role): 1379

The following are roles where I play a secondary role, and do not (necessarily) do monthly reports:
@ripcurlx ripcurlx mentioned this issue Feb 13, 2020
Open
@MwithM MwithM added this to In Progress in Compensation Requests Feb 13, 2020
This was referenced Feb 13, 2020
Closed
Open
Closed
@sqrrm
Copy link
Member

sqrrm commented Feb 14, 2020

This looks good to me

@ripcurlx ripcurlx changed the title [WIP] For Cycle 10 For Cycle 10 Feb 14, 2020
@MwithM MwithM moved this from In Progress to In Review in Compensation Requests Feb 14, 2020
@MwithM
Copy link
Contributor

MwithM commented Feb 14, 2020 •
edited
Loading

@sqrrm should @ripcurlx proceed to send DAO proposal and publish tx ID or should we wait for another approval?

Proposal phase ends 15 feb 06:00 GMT, block 617.466.

@ripcurlx
Copy link
Contributor Author

@MwithM I'll publish the DAO proposal now and if need be, delete and re-submit it again.

@ripcurlx
Copy link
Contributor Author

Proposal Transaction ID: 8732d7d63e203369a28e4ae3b8ebb9ab37c9f922806fde0b207a20e941cf3353

@sqrrm
Copy link
Member

sqrrm commented Feb 15, 2020

Sorry, didn't see the request for approval, I thought my initial comment was approval enough. Is there some phrasing that would make it clearer?

@MwithM
Copy link
Contributor

MwithM commented Feb 15, 2020 •
edited
Loading

I guess you can move it to "Review Complete" by yourself, but also if I see something like "proceed to publish tx ID" I'll do it.

@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Requests Feb 15, 2020
@cbeams cbeams added this to Proposal Submitted in Compensation Request Board Feb 17, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 22, 2020
@MwithM
Copy link
Contributor

MwithM commented Feb 22, 2020

Was accepted

@MwithM MwithM closed this as completed Feb 22, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Feb 22, 2020
@cbeams cbeams added this to the Cycle 10 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbeams cbeams

@sqrrm sqrrm

Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
  
Closed
Compensation Requests
  
Proposal Submitted
Milestone
Cycle 10
Development

No branches or pull requests
4 participants
@ripcurlx @cbeams @sqrrm @MwithM