Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS app Info.plist setting for automatic light/dark title bar #3883

Merged
merged 2 commits into from Jan 16, 2020

Conversation

@wiz
Copy link
Member

wiz commented Jan 9, 2020

macOS set to light theme:
Screen Shot 2020-01-10 at 8 07 35

macOS set to dark theme:
Screen Shot 2020-01-10 at 8 07 19

@wiz wiz requested review from ripcurlx and sqrrm as code owners Jan 9, 2020
@sqrrm

This comment has been minimized.

Copy link
Member

sqrrm commented Jan 10, 2020

@ripcurlx could you test this one?

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 13, 2020

@ripcurlx could you test this one?

sure

Co-Authored-By: Christoph Atteneder <christoph.atteneder@gmail.com>
Copy link
Member

ripcurlx left a comment

ACK

Create a local build and tested it by switching between:

  • dark mode
    Bildschirmfoto 2020-01-16 um 15 59 43
  • and light mode
    Bildschirmfoto 2020-01-16 um 15 59 50
@ripcurlx ripcurlx merged commit c50a761 into bisq-network:master Jan 16, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 16, 2020
@wiz wiz deleted the wiz:macos-dark-title-bar branch Jan 16, 2020
@wiz

This comment has been minimized.

Copy link
Member Author

wiz commented Feb 13, 2020

@ripcurlx FYI apparently this isn't the right shade of grey, it's supposed to be darker, will have to fix in a separate PR 😂

ripcurlx added a commit that referenced this pull request Feb 13, 2020
Causes issues on macOS versions before Catalina
ripcurlx added a commit that referenced this pull request Feb 13, 2020
Fixes issue #3969

This setting prevented the startup of the app on macOS Mojave.
Possibly on some other older macOS versions as well.
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.