Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of filtered offers and unsupported payment methods #4077

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Improve handling of filtered offers and unsupported payment methods #4077

merged 3 commits into from
Mar 19, 2020

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Mar 19, 2020 •
edited
Loading

Fixes #4076.

@ripcurlx ripcurlx requested a review from sqrrm March 19, 2020 09:12
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Mar 19, 2020
sqrrm
sqrrm approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

This should handle the issue of bad maxTradeLimit, but it doesn't fix the reason for the bad limit being set to begin with.

@sqrrm sqrrm merged commit 7056cff into bisq-network:master Mar 19, 2020
@ripcurlx ripcurlx added this to the v1.3.0 milestone Apr 1, 2020
@ripcurlx ripcurlx mentioned this pull request Apr 15, 2020
Closed
@ripcurlx ripcurlx deleted the handle-unsupported-payment-methods branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.

maxTradeLimit is not matching one of our default values. maxTradeLimit=0.00 BTC
2 participants
@ripcurlx @sqrrm