Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 12 #542

Closed
ripcurlx opened this issue Apr 15, 2020 · 4 comments
Closed

For Cycle 12 #542

ripcurlx opened this issue Apr 15, 2020 · 4 comments
Assignees
Labels
team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:growth https://bisq.wiki/Growth_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 15, 2020

Summary

  • BSQ requested:11851 (6.637 USD @ 0.56 USD/BSQ)

This is a compensation request for contributions delivered from last cycle until now (Apr 15).

Proposal transaction ID: 446df235a7bb9c23ef747d5e69f952d7adfa8a01fe38aa7d282abfd7e880a244

Contributions delivered

Reviews

Reviewed PRs:

View all reviewed PRs (28)

My PR reviews this month were created by reviewing the results of this GitHub Issues search query:
is:pr reviewed-by:ripcurlx updated:2020-03-15..2020-04-15 sort:updated-desc

Following PRs Review efforts are so small to track them separately:

Total USD amount for this remaining PRs: 150

USD amount requested: 1362

Development

I was working mainly on the v1.2.9, v1.3.0 and 1.3.1 releases and following PRs were merged to master.

View all merged PRs

My merged PRs this month were created by reviewing the results of this GitHub Issues search query:
is:pr author:ripcurlx is:merged merged:2020-03-15..2020-04-15 sort:updated-desc

USD amount requested: 200

Following PRs are covered by other role efforts already, are minor or not a prioritiy:

Testing

Tests for v1.3.0 and v1.3.1 were done untracked because of timely pressure. Besides that I took part in additional testing for our Tor v2/v3 upgrade which will be part of v1.3.2.

Test reports for the Tor v2/v3 upgrade can be found here:
https://bisq.ontestpad.com/project/1/folder/f60/report/?auth=8d8d89541d75bb7f52c85080959c3b72

Test reporting for v1.3.2 release testing can be found here: https://bisq.ontestpad.com/project/1/folder/f64/report/?auth=a62cf5de492c73850d6effc50b9fd7c9

USD amount requested: 540 USD

Release

To improve transparency I'll add the release efforts now separately and not combined with the Bisq Desktop Maintainer role anymore. Documentation of the release process can be found here.

The regular release v1.2.9 is part of this release item.

Because of the security vulnerability we had to release v1.3.0 and v.1.3.1 shortly after. This caused substantial more release efforts and testing for this hotfixes is also part of this item.

USD amount requested: 2700 USD

Support

Monitoring the support channel during my L2 times

Helping out L1 support whenever needed.

I didn't track unfortunately the single support cases this cycle, so I only have a total sum for all effort that went into support.

USD amount requested: 480 USD

Contributions in progress

I'm focusing right now on v1.3.2. I'm handing over my dev team lead role to @sqrrm as soon as I'm on paternity leave.
Besides that I'm working on account signing improvements.

All efforts for my role as dev team lead (roughly occupied ~60% of my time) won't be put up for compensation until it is proven to have the success we are looking for.

Roles performed

USD amount requested for all these roles (see detailed amount for each role): 1355 USD

The following are roles where I play a secondary role, and do not (necessarily) do monthly reports:

@MwithM MwithM added this to In Progress in Compensation Request Board Apr 15, 2020
@ripcurlx ripcurlx changed the title [WIP] For Cycle 12 For Cycle 12 Apr 15, 2020
@cbeams cbeams moved this from In Progress to In Review in Compensation Request Board Apr 16, 2020
@cbeams cbeams added this to the Cycle 12 milestone Apr 16, 2020
@cbeams cbeams added team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:growth https://bisq.wiki/Growth_Team labels Apr 16, 2020
@cbeams
Copy link
Member

cbeams commented Apr 16, 2020

@ripcurlx, I think you can eliminate these from future requests as they've each been closed:

And you can replace this with a link to a cycle report on the new Dev Team Lead role at bisq-network/roles#77 in future compensation requests:

All efforts for my role as dev team lead (roughly occupied ~60% of my time) won't be put up for compensation until it is proven to have the success we are looking for.

Otherwise, my team lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Apr 16, 2020
@ripcurlx
Copy link
Contributor Author

And you can replace this with a link to a cycle report on the new Dev Team Lead role at bisq-network/roles#77 in future compensation requests:

  • will do for the next cycle.

@ripcurlx
Copy link
Contributor Author

Proposal transaction ID: 446df235a7bb9c23ef747d5e69f952d7adfa8a01fe38aa7d282abfd7e880a244

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Apr 17, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 27, 2020
@MwithM
Copy link
Contributor

MwithM commented Apr 27, 2020

Closing as accepted.

@MwithM MwithM closed this as completed Apr 27, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Apr 27, 2020
@ripcurlx ripcurlx mentioned this issue Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:growth https://bisq.wiki/Growth_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

3 participants