Only use InputValidation when formatting voting stake #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
added
the
is:no-priority
sqrrm
reviewed
Mar 26, 2020
| @@ -554,6 +555,7 @@ private void updateViews() { | |||
| if (optionalMyVote.isPresent()) { | |||
| MyVote myVote = optionalMyVote.get(); | |||
| Coin stake = Coin.valueOf(myVote.getBlindVote().getStake()); | |||
| stakeInputTextField.setValidator(new InputValidator()); | |||
There was a problem hiding this comment.
Shouldn't this be set at line 676 instead of
stakeInputTextField.setValidator(new BsqValidator(bsqFormatter));
There was a problem hiding this comment.
No the validator there is fine. Just after submitting the vote the value entered is formatted with BSQ in the end which causes the original validator to fail. I think it is good that it is formatted with the code in this case so I didn't remove the formatting, but decided to adapt the validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is annoying me every time after voting I've added this no-priority fix.