Make prompt text readable in dark mode #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
added
the
is:no-priority
wiz
approved these changes
Mar 24, 2020
wiz
suggested changes
Mar 24, 2020
There was a problem hiding this comment.
Actually just noticed this
Mar 24, 2020 7:04:48 PM javafx.scene.CssStyleHelper calculateValue
WARNING: Caught 'java.lang.ClassCastException: java.base/java.lang.String cannot be cast to javafx.graphics@10.0.1/javafx.scene.paint.Color' while converting value for '-fx-prompt-text-fill' from rule '*.text-field' in stylesheet jar:file:/Applications/Bisq.app/Contents/Java/Bisq-1.2.9.jar!/bisq/desktop/bisq.css
Mar 24, 2020 7:04:48 PM javafx.scene.CssStyleHelper calculateValue
WARNING: Caught 'java.lang.ClassCastException: java.base/java.lang.String cannot be cast to javafx.graphics@10.0.1/javafx.scene.paint.Color' while converting value for '-fx-prompt-text-fill' from rule '*.text-field' in stylesheet jar:file:/Applications/Bisq.app/Contents/Java/Bisq-1.2.9.jar!/bisq/desktop/bisq.css
😬 good catch - I'll have a look why this is happening |
ripcurlx
force-pushed
the
make-prompt-text-readable-in-dark-mode
branch
from
9d92293
to
37751c7
Compare
|
I fixed a bug with another bug 😝 Just force-pushed the correct implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this annoys me for a long time when using dark mode, I quickly fixed this issue.
No compensation necessary - just fixing this was satisfaction enough ;-)
Before
After