Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give core api a simple way to verify init status #4534

Merged
merged 1 commit into from Sep 22, 2020

Conversation

ghubstan
Copy link
Member

This change adds a new StatusCheck class, for use by any Core*Service instance needing to verify the server is ready to perform trading related functions.

Currently implements one method, verifyCanTrade, that throws an IllegalStateException with a CLI friendly error message if any of the following checks fail:

  • the p2p network is bootstrapped
  • the block chain sync is complete
  • the minimum # of peers are connected
  • the wallet is available
  • the wallet balance is available (not null)

This change adds a new StatusCheck class, for use by Core*Service
instances needing to verify the server is ready to perform trading
related functions.

Currently implements one method, verifyCanTrade(), that throws an
IllegalStateException with a CLI friendly error message if any of
the following checks fail:

- the p2p network is bootstrapped
- the block chain sync is complete
- the minimum # of peers are connected
- the wallet is available
- the wallet balance is available (not null)
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 3d07c06 into bisq-network:master Sep 22, 2020
Ship Bisq Daemon and API automation moved this from In progress to Done Sep 22, 2020
@ghubstan ghubstan deleted the daemon-status-scratch branch September 22, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants