For Cycle 16

[ghubstan]

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

• BSQ requested: 14706
• USD requested: 10000
• BSQ rate: 0.68 USD per BSQ
• Previous compensation request (if applicable): For Cycle 15 #620

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title	Team	USD	Link	Notes
Add API test harness for Linux/OSX	dev	10000	bisq-network/bisq#4366	merged
Move gRPC boilerplate from :core to :daemon	dev	0	https://github.com/bisq-network/bisq/pull/44127	merged
Remove duplicate CompositeOptionSet class	dev	0	https://github.com/bisq-network/bisq/pull/44128	merged

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title	Team	USD	Link	Notes
Fix setUpScaffold() signature	dev	0	bisq-network/bisq#4429	merged
Move bats based mainnet test from :cli to :apitest	dev	0	bisq-network/bisq#4430	merged
Remove duplicated grpc stub creation logic	dev	0	bisq-network/bisq#4431	merged
Remove redundant ApiTestConfig options	dev	0	bisq-network/bisq#4432	merged
Allow remote debugging of background Bisq apps	dev	0	bisq-network/bisq#4433	merged
Make CoreApi a singleton	dev	---	bisq-network/bisq#4461	merged
Add core support for registration of regtest dispute agents via API	dev	---	bisq-network/bisq#4524	merged
Refactor API & add registerdisputeagent method to CLI	dev	---	bisq-network/bisq#4539	awaiting review
Refactor apitest for api calls to any daemon type	dev	---	bisq-network/bisq#4525	merged
Give core api a simple way to verify init status	dev	---	bisq-network/bisq#4534	awaiting review
Reduce apitest harness' dependency on string matching	dev	---	bisq-network/bisq#4540	awaiting review

[sqrrm]

I have a hard time valuing this work. While we do need a test framework and I think the code is good, there is a lot of money going into code that's not actually useful for end users.

On the other hand, we have previously been severely lacking in tests, and this framework will allow us to set up more live like tests. Very good stuff, but useless if Bisq is no longer around.

I suggest that we should focus on producing features for api users going forward, especially now that we have this test framework. There will likely be traders that are happy to start tinkering at that point and we will quickly learn where we need to focus.

[ripcurlx]

Sorry for jumping in that late because of vacation. I agree what @sqrrm is mentioning above. I'll have a look if the Codacy issues are wrong so it can be merged to master and compensated.

[ghubstan]

@sqrrm @ripcurlx:

I have a hard time valuing this work...

I expected this valid questioning and pushback to the CR. I can be flexible about the amount requested, but when I was ready to submit the PR about a month ago, I thought it was worth more than 10K USD.

Let me respond to your comments and give you my plan for the next phase of development. Maybe it will help you decide to approve this CR as is, or not.

Although the apitest harness gives no benefits to Bisq users today, it can provide benefits to other code contributors now, and the test harness will benefit the ongoing work on the API, which I will talk about in a moment.

Below is a list of tasks I am currently working on, starting with the work already done, and saved in a scratch branch.

Finish and fix apitest functionality (already done, to go into new PRs but not to be compensated):

• Fix test case setup method to accept any combination of options
• Move :cli/test.sh to :apitest/scripts/mainnet-test.sh
• Remove duplicated gRPC stub creation logic
• Remove 3 redundant config options
• Add option to run background Bisq apps with remote debug options

Below are descriptions of two completed tasks I will add to new PRs, and be part of my next CR (Cycle 17):

1. I had to upgrade JFoenix to v9.0.10 in my scratch branch, to avoid an NPE being thrown when I try to register a dispute agent in an arb desktop running in regtest/dao mode. I came across this JFoenix lib bug while using apitest to figure out how get the API to register dispute and refund agents -- required for trading with the API.

2. I completed one task directly related to the API, a new ping method to be used for checking server availability before any request.

The next task is figure out how, then implement registration of dispute and refund agents in an arbitration :daemon.

After that, I go back to the "simplest trading script" task list defined in Issue 4257, and implmenent creatoffer, confirmoffer, takeoffer, confirmtakeoffer, getofferstatus, paymentstarted, paymentreceived, canceloffer, movefunds, and withdrawfunds methods and test cases.

Now that apitest is out of the way, I can focus on the "simple api trading" script work again. I do think I have a good chance of implementing all or most of these new methods in the next 3-4 weeks (if apitest is truly "out of the way"). This is when the benefits of apitest will become more tangible.

[ghubstan]

The apitest related scratch branch commits I mentioned above are now PRs, and listed in the Contributions in progress section of this CR.

[sqrrm]

Having considered this a bit further, I approve of this compensation request seeing it as a part of the whole API project. It's already able to run the tests which is something we haven't been able to do before. It will also help speed up the upcoming API dev.

[ghubstan]

Proposal tx: 0128c8cb88438563afea73b5cb5fbc77eff6eb87be16634f87efb0eb94d6c112

[bisq-bot]

Issuance by Team:

team	amount BSQ	amount USD
dev	14706.00	10000.00

Total Issuance: 14706.00 BSQ (equivalent to: 10000.00 USD)

[MwithM]

was:accepted