Refactor API & add registerdisputeagent method to CLI #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains most of the changes suggested by @chimp1984 in his api-suggestions branch. See bisq-network@961703e A new 'registerdisputeagent' method was also added to MainCli, finishing the work to support registration of mediators and refund agents on arbitration daemons running in regtest mode. This method cannot be used to register dispute agents on mainnet; users will see an error msg if they try.
This was referenced Sep 20, 2020
chimp1984
reviewed
Sep 21, 2020
| accountNumber, | ||
| currencyCode); | ||
|
|
||
| // TODO not sure if there is more to do at account creation. |
There was a problem hiding this comment.
Yes there is lots of extra stuff, mainly the many different payment methods with their custom requirements. Input validation, currency selection, country selection, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains most of the changes suggested by @chimp1984 in his api-suggestions branch. See 961703e
A new
registerdisputeagentmethod was also added toCliMain, finishing the work to support registration of mediators and refund agents on arbitration daemons running in regtest mode. This method cannot be used to register dispute agents on mainnet; users will see an error msg if they try. (The change was added to this PR to avoid likelyCliMainfile conflicts.)This PR replaces 4526.