Cleanup trade wallet code #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubstan
reviewed
Dec 24, 2020
| * Holds the relevant data for the connected output for a tx input. | ||
| * ParentTransaction means here the spending tx, the tx of the output not the parentTransaction of the input itself. | ||
| * Also index refers to the index of the spending output | ||
| */ |
There was a problem hiding this comment.
I would reformat the method javadoc with some minor grammar changes:
/**
* Holds the relevant data for the connected output for a tx input.
* @param index the index of the parentTransaction
* @param parentTransaction the spending output tx, not the parent tx of the input
* @param value the number of satoshis being spent
*/
There was a problem hiding this comment.
Thanks, will do a commit a bit later (in the middle of some other works atm...)
ghubstan
previously approved these changes
Dec 24, 2020
jmacxx
previously approved these changes
Dec 27, 2020
| TransactionOutput hashedMultiSigOutput = new TransactionOutput(params, null, msOutputValue, hashedMultiSigOutputScript.getProgram()); | ||
| Transaction depositTx = new Transaction(params); | ||
| depositTx.addOutput(hashedMultiSigOutput); | ||
|
|
There was a problem hiding this comment.
👍 @chimp1984 thanks for finding this! 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.