Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 22 #783

Closed
chimp1984 opened this issue Feb 10, 2021 · 9 comments
Closed

For Cycle 22 #783

chimp1984 opened this issue Feb 10, 2021 · 9 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@chimp1984
Copy link

chimp1984 commented Feb 10, 2021

Summary

Due to limtations of max. issuance per cycle I recommened to reject that requests in cycle 21, so I repeat it here with the same rate and amount as before.

  • BSQ requested: 31133.33
  • USD requested: 23350
  • BSQ rate: 0.75 USD per BSQ

Contributions delivered

Title Team USD Link Notes
UI improvements dev 300 bisq-network/bisq#4914 -
Property fields must not be set from non JavaFX threads dev 50 bisq-network/bisq#4916 -
Detect and handle invalid maker fee tx dev 300 bisq-network/bisq#4917 -
Revert TTL to original value of 15 days dev 0 bisq-network/bisq#4920 -
Detect missing deposit tx to allow moving to failed trades dev 200 bisq-network/bisq#4921 -
Fix sorting of table columns dev 100 bisq-network/bisq#4923 -
Improve shutdown routine dev 100 bisq-network/bisq#4927 -
Make sign age column sortable dev 300 bisq-network/bisq#4929 -
Use HistoricalDataStoreService for AccountAgeWitnessStorageService dev 300 bisq-network/bisq#4930 -
Improve funds and portfolio screens dev 400 bisq-network/bisq#4933 -
Add wallet info view dev 500 bisq-network/bisq#4935 -
Refactor http client dev 300 bisq-network/bisq#4942 -
Add tx broadcast to mempool explorer api dev 1300 bisq-network/bisq#4943 -
Improve TransferWise account dev 100 bisq-network/bisq#4944 -
Fix bug with maker fee tx at create offer dev 100 bisq-network/bisq#4947 -
Show price deviation in % for fixed price offers and BSQ dev 900 bisq-network/bisq#4949 -
Allow sending private notifications from avatar icon at trade dev 100 bisq-network/bisq#4952 -
Cache results in account witness domain dev 600 bisq-network/bisq#4953 Includes Profiling work
Various small improvements dev 100 bisq-network/bisq#4954 -
Cache results of isFiatCurrency and isCryptoCurrency dev 400 bisq-network/bisq#4955 Profiling was main effort here
Sort payment methods by display string not by id dev 50 bisq-network/bisq#4956 -
Do not use tx broadcast to mempool nodes if a local btc nodes is used dev 100 bisq-network/bisq#4958 -
Call completeHandler if services in store services is empty dev 200 bisq-network/bisq#4963 -
Avoid resync from genesis in case of dao state issues dev 300 bisq-network/bisq#4971 -
Improve logs dev 100 bisq-network/bisq#4973 -
Fix nullpointer dev 0 bisq-network/bisq#4974 -
Improve CleanupMailboxMessages dev 400 bisq-network/bisq#4975 -
Remove NGN (Nigerian Naira) as their central bank blocked Transferwise dev 50 bisq-network/bisq#4976 -
Add extra note for amazon gift cards dev 100 bisq-network/bisq#4977 -
Fix wrong account age data access dev 200 bisq-network/bisq#4981 Includes debugging efforts
Improve popup text in case a local node is detected dev 50 bisq-network/bisq#4984 -
Improve trade fee display at create and take offer screens and popups dev 400 bisq-network/bisq#4985 -
Remove redundant popup dev 50 bisq-network/bisq#4987 -
Add mediators keybase usernames dev 100 bisq-network/bisq#5004 -
Improve offer publishing dev 300 bisq-network/bisq#4950 -
Move BSQ price in USD at first row dev 50 bisq-network/bisq#4988 -
Add percentage price to open offer view dev 200 bisq-network/bisq#4993 -
Cleanup trade wallet code dev 50 bisq-network/bisq#4997 -
Add generic map (cookie) to UserPayload dev 300 bisq-network/bisq#4999 -
Deactivate open offer if trigger price is reached dev 2300 bisq-network/bisq#5001 -
Add estimated size to log of initial data response dev 50 bisq-network/bisq#5009 -
Dao performance improvements dev 50 bisq-network/bisq#5010 -
Show stacktrace in error popup at view exceptions dev 50 bisq-network/bisq#5011 -
Change trade period for transferwise from 1 day to 4 days dev 150 bisq-network/bisq#5016 Effort was testing backward compitability
Improve getBlocks request handling dev 400 bisq-network/bisq#4851 -
Add dos protection dev 200 bisq-network/bisq#5026 -
We need to use the getMapOfAllData method for HistoricalDataStoreServices dev 100 bisq-network/bisq#5030 -
Access concrete data stores dev 100 bisq-network/bisq#5031 -
Check for duplicate hashes at onBundleOfEnvelopes dev 100 bisq-network/bisq#5032 -
Only publish witness if we are in date tolerance dev 100 bisq-network/bisq#5033 -
Add filter support on network level dev 600 bisq-network/bisq#5038 -
Add option to prevent periodic shutdown for seed nodes dev 50 bisq-network/bisq#5039 -
Request only non-seed nodes if no seed nodes are available dev 50 bisq-network/bisq#5041 -
Select show-all currencies if TransferWise is selected dev 100 bisq-network/bisq#5042 -
Add option to hide non supported payment methods dev 200 bisq-network/bisq#5045 -
Add cache for signature verification results and a lookup map by ownerPubKey dev 400 bisq-network/bisq#5047 -
Add toggle for hiding not takable offers dev 300 bisq-network/bisq#5048 -
Add protection tool dev 300 bisq-network/bisq#5053 -
Add csv export to bsq tx view dev 200 bisq-network/bisq#5054 -
Fix premature disconnections from seeds dev 600 bisq-network/bisq#5057 -
Persist failed attempts of decrypting mailbox messages dev 800 bisq-network/bisq#5061 -
Add toggle for displaying volume in tradestatistics chart in USD dev 800 bisq-network/bisq#5066 -
Improve cleanup tor dir at seeds dev 50 bisq-network/bisq#5070 -
Persist and republish mailbox messages dev 3000 bisq-network/bisq#5072 -
Change rule for "reason for payment" field to not use trade ID but leave it empty dev 300 bisq-network/bisq#5080 -
Fix bug with ignoreLocalBtcNode dev 50 bisq-network/bisq#5094 -
Release testing dev 500 - -
Technical user support support 2000 - -

Note:

I added contributions from the start of cycle 20 only (9.12.2020). I did not request compensation of my work of the past months, but might add that to future requests.

@bisq-bot bisq-bot bot added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team labels Feb 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Feb 10, 2021

Will you make two different proposals with two different rates for tasks done during Cycle 22?
This way there will be no confusion with the rates to use. I think it's better, specially considering they are for a high amount.

@chimp1984
Copy link
Author

Yes, I will make 2 diff. requests. This is the exact copy which only got delayed to not cause a failed cycle.

@chimp1984 chimp1984 changed the title For Cycle 22 For Cycle 22 (from cycle 21) Feb 19, 2021
@chimp1984 chimp1984 changed the title For Cycle 22 (from cycle 21) For Cycle 22 Feb 20, 2021
@MwithM MwithM added this to the Cycle 22 milestone Feb 21, 2021
@MwithM MwithM added this to In Review in Compensation Request Board Feb 21, 2021
@chimp1984
Copy link
Author

txid: 293d91e325fdb3092ca8b1ac19a8ac22a337b9832c94d41b0d086315829e7b0d

@leo816
Copy link

leo816 commented Mar 2, 2021

My Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Mar 2, 2021
@ripcurlx
Copy link
Member

ripcurlx commented Mar 3, 2021

As team lead I approve this request for dev.

@MwithM
Copy link
Contributor

MwithM commented Mar 8, 2021

Reminder: please submit the TXID of the DAO proposal.

@chimp1984
Copy link
Author

Reminder: please submit the TXID of the DAO proposal.

#783 (comment)

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Mar 8, 2021
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 15, 2021
@bisq-bot
Copy link

bisq-bot bot commented Mar 15, 2021

Issuance cannot be displayed as there were errors in the comp request

@MwithM
Copy link
Contributor

MwithM commented Mar 15, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Mar 15, 2021
Compensation Request Board automation moved this from Proposal Submitted to Closed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

4 participants