Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some trade simulation functions re-usable #5128

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Make some trade simulation functions re-usable #5128

merged 3 commits into from
Feb 3, 2021

Commits on Jan 25, 2021

  1. Fix bash syntax inconsistencies 

    Many unnecesary braces around ${VARIABLE} references were removed.
    @ghubstan
    ghubstan committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    30a0f99 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Refactor createpaymentacct and trade protocol functions 

    Code duplication needs to be reduced as new scripts are added.

- Refactor the createpaymentacct functions.
  The steps required to create a payment account are still
  displayed, but only for Alice, not Bob.

- Treat the trade protocol simulation as an atomic function.
  This will reduce 'main' simulation script size as new
  ones are added.
    @ghubstan
    ghubstan committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5a78d18 View commit details
    Browse the repository at this point in the history

  2. Move createoffer command generation to its own function

    @ghubstan
    ghubstan committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    74008e9 View commit details
    Browse the repository at this point in the history