Make some trade simulation functions re-usable #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many unnecesary braces around ${VARIABLE} references were removed.
Code duplication needs to be reduced as new scripts are added. - Refactor the createpaymentacct functions. The steps required to create a payment account are still displayed, but only for Alice, not Bob. - Treat the trade protocol simulation as an atomic function. This will reduce 'main' simulation script size as new ones are added.
sqrrm
approved these changes
Feb 3, 2021
I wanted the calling scripts to be simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code duplication needs to be reduced as new scripts are added.
Refactor the
createpaymentacctfunctions.The steps required to create a payment account are still displayed, but only for Alice, not Bob.
Treat the trade protocol simulation as an atomic function.
This will reduce 'main' simulation script size as new ones are added.
Move
createoffercommand generation to its own function.This PRs branch was created off
01-fix-bash-syntax, and #5116 needs to be reviewed and merged before this one.