Fix prompt labels overflows in create order #5251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've created a class StringUtils located in common/util. StringUtils.truncatePromptString is used five times in MutableOfferView.java directly on the prompt value. It is also used once in MutableOfferViewModel.java for the volume prompt which is a interpolated string
|
Thanks for opening this pull request! |
|
I am honestly not sure if there was a simpler solution to fix this. Maybe someone will know more about javafx and its CSS rules and can suggest a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5189
This change is to fix the prompt labels that where overflowing
outside the InputTextBoxes in the CreateOffer section (Buy and Sell).