Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt text overflow in create order #5256

Closed
wants to merge 0 commits into from
Closed

Fix prompt text overflow in create order #5256

wants to merge 0 commits into from

Conversation

forcryptos
Copy link

@forcryptos forcryptos commented Feb 28, 2021

Added StringUtils class with truncatePromptText method.

truncatePromptText is called in MutableOfferView(5) and
in MutableOfferViewModel(1) to cut too long text.

Fixes #5189

Copy link
Contributor

@wallclockbuilder wallclockbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtAck

@ripcurlx
Copy link
Member

ripcurlx commented Mar 9, 2021

I think this should be handled differently. I'm quite sure the auto-truncation of the prompt text is a supported feature, but it just doesn't work because input.setMaxWidth(Double.MAX_VALUE); is set in getEditableValueBox. I didn't have time to look into it in more detail, but I think this is the way to fix this issue.

@forcryptos forcryptos closed this Mar 10, 2021
@forcryptos forcryptos deleted the fix-create-offer-prompt-text-overflow branch March 10, 2021 04:49
@forcryptos forcryptos restored the fix-create-offer-prompt-text-overflow branch March 10, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger price truncation of prompt text not working
3 participants