Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new api method 'editoffer' #5572

Merged
merged 26 commits into from
Aug 30, 2021
Merged

Add new api method 'editoffer' #5572

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
81da6fb
Refactor EditOfferDataModel for new editoffer api method
ghubstan Jun 12, 2021
d9dd718
Fix comment
ghubstan Jun 12, 2021
1daf471
Add OfferInfo field isActivated, rpc EditOffer to proto
ghubstan Jun 13, 2021
2b8b53b
Add server/core editOffer, adjust getMyOffer(s) impls
ghubstan Jun 13, 2021
9231e48
Refactor GrpcClient: request builders moved bisq.cli.request pkg
ghubstan Jun 13, 2021
d2939cc
Add new EditOfferOptionParser and test
ghubstan Jun 13, 2021
2344285
Add editoffer method help
ghubstan Jun 13, 2021
be249c5
Add editoffer to CLI
ghubstan Jun 13, 2021
929b28c
Add editoffer api tests & minor apitest refactoring
ghubstan Jun 13, 2021
571568a
Remove chase quickpay acct test
ghubstan Jun 13, 2021
9a5e2d0
Remove unused import
ghubstan Jun 13, 2021
05f3985
Fix problems found in codacy check
ghubstan Jun 13, 2021
54efad0
Fix codacy issue
ghubstan Jun 13, 2021
21ac46a
Fix log arg spec bug
ghubstan Jun 13, 2021
32688a7
Add bool isMyOffer to OfferInfo proto
ghubstan Jun 15, 2021
738d2f7
Fix editoffer validation bugs, tidy up CoreOffersService
ghubstan Jun 15, 2021
e2a205a
Show enable/trigger-price cols for 'getmyoffer'
ghubstan Jun 15, 2021
4da64b9
Improve 'editoffer' opt parsing, fix test pkg name
ghubstan Jun 15, 2021
063b52e
Add editoffer test case, suppress annoying warnings
ghubstan Jun 15, 2021
e5b5a06
Remove unused field
ghubstan Jun 15, 2021
bc1576e
Throw exception is edit altcoin offer is attempted
ghubstan Jun 15, 2021
a3ea4ec
Avoid duplicate test run
ghubstan Jun 15, 2021
3d38a85
Make codacy just a bit happier
ghubstan Jun 15, 2021
1a56a51
Force codacy check after codacy config change
ghubstan Jun 17, 2021
ab2edac
Merge branch 'master' into 02-refactor-for-api-editoffer-method
ghubstan Jun 19, 2021
0a3e011
Merge branch '02-refactor-for-api-editoffer-method' into 03-api-edito…
ghubstan Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public void testBuyOfferAutoDisable(final TestInfo testInfo) {
int numIterations = 0;
while (++numIterations < MAX_ITERATIONS) {
offer = aliceClient.getMyOffer(offer.getId());
;

var mktPrice = aliceClient.getBtcPrice("USD");
if (offer.getIsActivated()) {
log.info("Offer still enabled at mkt price {} < {} trigger price",
Expand Down
1 change: 1 addition & 0 deletions core/src/main/java/bisq/core/api/CoreOffersService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import static bisq.common.util.MathUtils.scaleUpByPowerOf10;
import static bisq.core.locale.CurrencyUtil.isCryptoCurrency;
import static bisq.core.offer.Offer.State;
import static bisq.core.offer.Offer.State.*;
import static bisq.core.offer.OfferPayload.Direction;
import static bisq.core.offer.OfferPayload.Direction.BUY;
import static bisq.core.offer.OpenOffer.State.AVAILABLE;
Expand Down