Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api beta test guide: add 'editoffer' #5577

Merged
merged 47 commits into from Aug 30, 2021
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
81da6fb
Refactor EditOfferDataModel for new editoffer api method
ghubstan Jun 12, 2021
d9dd718
Fix comment
ghubstan Jun 12, 2021
1daf471
Add OfferInfo field isActivated, rpc EditOffer to proto
ghubstan Jun 13, 2021
2b8b53b
Add server/core editOffer, adjust getMyOffer(s) impls
ghubstan Jun 13, 2021
9231e48
Refactor GrpcClient: request builders moved bisq.cli.request pkg
ghubstan Jun 13, 2021
d2939cc
Add new EditOfferOptionParser and test
ghubstan Jun 13, 2021
2344285
Add editoffer method help
ghubstan Jun 13, 2021
be249c5
Add editoffer to CLI
ghubstan Jun 13, 2021
929b28c
Add editoffer api tests & minor apitest refactoring
ghubstan Jun 13, 2021
571568a
Remove chase quickpay acct test
ghubstan Jun 13, 2021
9a5e2d0
Remove unused import
ghubstan Jun 13, 2021
05f3985
Fix problems found in codacy check
ghubstan Jun 13, 2021
54efad0
Fix codacy issue
ghubstan Jun 13, 2021
21ac46a
Fix log arg spec bug
ghubstan Jun 13, 2021
32688a7
Add bool isMyOffer to OfferInfo proto
ghubstan Jun 15, 2021
738d2f7
Fix editoffer validation bugs, tidy up CoreOffersService
ghubstan Jun 15, 2021
e2a205a
Show enable/trigger-price cols for 'getmyoffer'
ghubstan Jun 15, 2021
4da64b9
Improve 'editoffer' opt parsing, fix test pkg name
ghubstan Jun 15, 2021
063b52e
Add editoffer test case, suppress annoying warnings
ghubstan Jun 15, 2021
e5b5a06
Remove unused field
ghubstan Jun 15, 2021
bc1576e
Throw exception is edit altcoin offer is attempted
ghubstan Jun 15, 2021
a3ea4ec
Avoid duplicate test run
ghubstan Jun 15, 2021
3d38a85
Make codacy just a bit happier
ghubstan Jun 15, 2021
1a56a51
Force codacy check after codacy config change
ghubstan Jun 17, 2021
0e9c665
Include isMyOffer flag in API's trade/offer proto wrappers
ghubstan Jun 18, 2021
a603044
Pass isMyOffer flag to trade/offer proto wrappers from core services
ghubstan Jun 18, 2021
e32e0d1
Add altcoin (bsq) offer editing validation check
ghubstan Jun 18, 2021
b74f084
Optionally show ENABLED column in CLI's getoffer(bsq) output
ghubstan Jun 18, 2021
7880a84
Add BSQ offer editing tests to EditOfferTest
ghubstan Jun 18, 2021
ab2edac
Merge branch 'master' into 02-refactor-for-api-editoffer-method
ghubstan Jun 19, 2021
0a3e011
Merge branch '02-refactor-for-api-editoffer-method' into 03-api-edito…
ghubstan Jun 19, 2021
8115866
Merge branch '03-api-editoffer-method' into 04-edit-bsq-offer
ghubstan Jun 19, 2021
acbf1e4
Force rebuild after github action ECONNRESET
ghubstan Jun 19, 2021
9703b87
Document api 'editoffer' usage
ghubstan Jun 19, 2021
05f4f4d
Fix header
ghubstan Jun 19, 2021
06efcdf
Delete tmp main() method
ghubstan Jul 11, 2021
eb62f93
Rename and move private function
ghubstan Jul 12, 2021
1992bcb
Do not duplicate Price.parse on CLI side for only one use case
ghubstan Jul 12, 2021
622f7e9
Remove old TODO because relevant refactoring was approved
ghubstan Jul 12, 2021
a4278a4
Fix typo 'enabled' -> 'enable'
ghubstan Jul 13, 2021
649c98a
Always use Locale.US in CLI DecimalFormats
ghubstan Jul 15, 2021
b8379e2
Merge branch 'master' into 05-update-api-beta-test-guide
ghubstan Jul 30, 2021
b4ee6db
Do not start test harness deamons in dbg mode by default
ghubstan Jul 30, 2021
95bbb41
Add missing trigger-price param
ghubstan Jul 30, 2021
add6536
Fix peer add(offer) & remove(offer) event order problem
ghubstan Jul 30, 2021
094bc52
Revert "Fix peer add(offer) & remove(offer) event order problem"
ghubstan Aug 2, 2021
3693728
Merge branch 'master' into 05-update-api-beta-test-guide
ghubstan Aug 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -54,6 +54,7 @@
import static protobuf.OfferPayload.Direction.BUY;
import static protobuf.OfferPayload.Direction.SELL;

@SuppressWarnings("ConstantConditions")
@Disabled
@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
Expand Down Expand Up @@ -258,16 +259,6 @@ public void testCreateUSDBTCBuyOfferWithTriggerPrice() {
assertEquals(triggerPriceAsLong, newOffer.getTriggerPrice());
}

public static void main(String[] args) {
// TODO DELETE ME
String triggerPriceAsString = "10.1111";
Price price = Price.parse("USD", triggerPriceAsString);
long triggerPriceAsLong = price.getValue();
log.info("triggerPriceAsString: {}", triggerPriceAsString);
log.info("triggerPriceAsPrice: {}", price);
log.info("triggerPriceAsLong: {}", triggerPriceAsLong);
}

private void assertCalculatedPriceIsCorrect(OfferInfo offer, double priceMarginPctInput) {
assertTrue(() -> {
String counterCurrencyCode = offer.getCounterCurrencyCode();
Expand Down