Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I2P as enum entry #5840

Merged

Conversation

chimp1984
Copy link
Contributor

After a seed node has updated Bitcoin Core to v22 he got the error posted below.
It seems I2P was added as enum value and our json parsing does not tolerate newly added values.
I think it would be good to add some error handling to not cause a fatal failure in such cases, but I am not familiar with that part of the code and with the used json library. This PR should at least fixe quickly the issue.

Nov-18 16:53:32.739 [RpcService] ERROR b.c.d.n.f.RpcService: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo$NetworkType` from String "i2p": not one of the values accepted for Enum class: [onion, ipv4, ipv6] at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo["networks"]->
java.util.ArrayList[3]->bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo$Network["name"]) 
Nov-18 16:53:32.741 [SeedNodeMain] ERROR b.c.d.n.f.FullNode: An error occurred:Error=bisq.core.dao.node.full.RpcException: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `bisq.core.dao.node.full.rpc.dto.DtoNetworkI
nfo$NetworkType` from String "i2p": not one of the values accepted for Enum class: [onion, ipv4, ipv6] at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo["networks"]->
java.util.ArrayList[3]->bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo$Network["name"]) 
Nov-18 16:53:32.742 [SeedNodeMain] ERROR b.c.a.m.AppSetupWithP2PAndDAO: An error occurred: Error=bisq.core.dao.node.full.RpcExcept
ion: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `bisq.core.dao.node.full.rpc.dto.
DtoNetworkInfo$NetworkType` from String "i2p": not one of the values accepted for Enum class: [onion, ipv4, ipv6]
 at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo["networks"]->
java.util.ArrayList[3]->bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo$Network["name"]) 

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.0 milestone Nov 18, 2021
@ripcurlx ripcurlx merged commit b5a43c7 into bisq-network:master Nov 18, 2021
@chimp1984 chimp1984 deleted the add-i2p-to-btc-core-networktypes branch November 21, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants