Enable fractional percentages in dispute payout calculation field #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 8, 2022
| @@ -963,7 +963,7 @@ private void applyUiControlsToDisputeResult(Toggle selectedTradeAmountToggle) { | |||
|
|
|||
| Coin penalizedPortionOfTradeAmount = Coin.ZERO; | |||
| try { | |||
| disputeResult.setPayoutAdjustmentPercent(compensationOrPenalty.getText().replaceAll("[^0-9]", "")); | |||
| disputeResult.setPayoutAdjustmentPercent(compensationOrPenalty.getText().replaceAll("[^0-9,.]", "")); | |||
There was a problem hiding this comment.
What about changing type of payoutAdjustmentPercent to double instead of String, and handling this replaceAll logic inside ParsingUtils.parsePercentStringToDouble method?
There was a problem hiding this comment.
@xyzmaker123 thankyou for the review. However I sincerely believe in this case that it would be better remaining as is.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leo816 requested the ability to enter fractional percentages in the dispute payout calculation window.
Either a comma (1,23) or a period (1.23) may be used as the fractional delimiter.